From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:34545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjUy8-0007Bc-KH for qemu-devel@nongnu.org; Tue, 15 Jan 2019 15:05:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gjUy3-00032U-7R for qemu-devel@nongnu.org; Tue, 15 Jan 2019 15:05:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29717) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gjUy1-0002ur-4D for qemu-devel@nongnu.org; Tue, 15 Jan 2019 15:05:45 -0500 Date: Tue, 15 Jan 2019 15:05:27 -0500 From: "Michael S. Tsirkin" Message-ID: <20190115150238-mutt-send-email-mst@kernel.org> References: <20190115100058.44712-1-sgarzare@redhat.com> <20190115100058.44712-5-sgarzare@redhat.com> <20190115135548-mutt-send-email-mst@kernel.org> <3db58f6f-44fc-da64-2cfb-41404a9b2319@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3db58f6f-44fc-da64-2cfb-41404a9b2319@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 4/4] hw/i386/pc: use PVH option rom List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Stefano Garzarella , qemu-devel@nongnu.org, Boris Ostrovsky , Eduardo Habkost , Gerd Hoffmann , George Kennedy , Marcel Apfelbaum , Paolo Bonzini , Marc-Andre Lureau , Richard Henderson , Stefan Hajnoczi , Liam Merwick , Maran Wilson On Tue, Jan 15, 2019 at 01:12:21PM -0600, Eric Blake wrote: > On 1/15/19 12:57 PM, Michael S. Tsirkin wrote: > > On Tue, Jan 15, 2019 at 11:00:58AM +0100, Stefano Garzarella wrote: > >> Use pvh.bin option rom when we are booting an uncompressed > >> kernel using the x86/HVM direct boot ABI. > >> > >> Signed-off-by: Stefano Garzarella > >> Based-on: <1545422632-24444-5-git-send-email-liam.merwick@oracle.com> > > > > I don't think this is a great way to give attribution. > > Can you pls include the author name and the S.O.B from there as well? > > > > > >> --- > > Patchew understands Based-on: tags as meaning a prerequisite patch on > the list that must be applied first before this patch can apply (and NOT > in the sense that this patch is an updated revision to replace an > earlier revision posted by someone else) - but when using the annotation > to keep Patchew happy, it should either be in a 0/N cover letter, or for > a single patch, after the --- separator, as the condition of a > prerequisite patch not being applied is a transient condition relevant > to the current build but not something that needs to be recorded in > long-term git history. > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3226 > Virtualization: qemu.org | libvirt.org > Good to know. But I still think listing the original author (e.g. Based on patches by Foo Bar) or such is the nice thing to do. -- MST