From: Stefano Garzarella <sgarzare@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Liam Merwick <liam.merwick@oracle.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
Maran Wilson <maran.wilson@oracle.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Eric Blake <eblake@redhat.com>,
Richard Henderson <rth@twiddle.net>,
George Kennedy <george.kennedy@oracle.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg
Date: Thu, 17 Jan 2019 15:53:37 +0100 [thread overview]
Message-ID: <20190117145337.zz3xi2bav33s67lc@steredhat> (raw)
In-Reply-To: <aa7f4f9e-90b2-c53c-9ddb-b27fd2977d2d@redhat.com>
On Thu, Jan 17, 2019 at 03:37:24PM +0100, Paolo Bonzini wrote:
> On 17/01/19 15:33, Liam Merwick wrote:
> > # pc-bios/optionrom/pvh.bin
> > # pc-bios/optionrom/pvh.img
> > # pc-bios/optionrom/pvh.raw
Thanks Liam!
>
> pvh.bin should not be ignored.
I committed pc-bios/pvh.bin, but I think we should ignore the
pc-bios/optionrom/pvh.bin like for the other optionroms (eg.
pc-bios/optionrom/linuxboot_dma.bin is present in .gitignore)
What do you think if I add the following at patch 3/5?
diff --git a/.gitignore b/.gitignore
index 0430257313..321095bf1a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -103,6 +103,10 @@
/pc-bios/optionrom/linuxboot_dma.bin
/pc-bios/optionrom/linuxboot_dma.raw
/pc-bios/optionrom/linuxboot_dma.img
+/pc-bios/optionrom/pvh.asm
+/pc-bios/optionrom/pvh.bin
+/pc-bios/optionrom/pvh.raw
+/pc-bios/optionrom/pvh.img
/pc-bios/optionrom/multiboot.asm
/pc-bios/optionrom/multiboot.bin
/pc-bios/optionrom/multiboot.raw
Thanks,
Stefano
prev parent reply other threads:[~2019-01-17 14:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 9:02 [Qemu-devel] [PATCH v4 0/5] pvh: add new PVH option rom Stefano Garzarella
2019-01-17 9:02 ` [Qemu-devel] [PATCH v4 1/5] linuxboot_dma: remove duplicate definitions of FW_CFG Stefano Garzarella
2019-01-17 9:02 ` [Qemu-devel] [PATCH v4 2/5] linuxboot_dma: move common functions in a new header Stefano Garzarella
2019-01-17 9:02 ` [Qemu-devel] [PATCH v4 3/5] optionrom: add new PVH option rom Stefano Garzarella
2019-01-17 9:02 ` [Qemu-devel] [PATCH v4 4/5] hw/i386/pc: use " Stefano Garzarella
2019-01-17 9:02 ` [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg Stefano Garzarella
2019-01-17 10:19 ` Stefan Hajnoczi
2019-01-17 14:33 ` Liam Merwick
2019-01-17 14:37 ` Paolo Bonzini
2019-01-17 14:52 ` Liam Merwick
2019-01-17 15:05 ` Stefano Garzarella
2019-01-17 15:18 ` Paolo Bonzini
2019-01-17 16:13 ` Stefano Garzarella
2019-01-17 17:57 ` Paolo Bonzini
2019-01-17 14:53 ` Stefano Garzarella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190117145337.zz3xi2bav33s67lc@steredhat \
--to=sgarzare@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=george.kennedy@oracle.com \
--cc=liam.merwick@oracle.com \
--cc=maran.wilson@oracle.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).