From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:56111)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sgarzare@redhat.com>) id 1gk94c-000477-HF
	for qemu-devel@nongnu.org; Thu, 17 Jan 2019 09:55:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sgarzare@redhat.com>) id 1gk939-0000IB-Lw
	for qemu-devel@nongnu.org; Thu, 17 Jan 2019 09:53:44 -0500
Received: from mail-wr1-f68.google.com ([209.85.221.68]:45834)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <sgarzare@redhat.com>) id 1gk939-0000Eh-FJ
	for qemu-devel@nongnu.org; Thu, 17 Jan 2019 09:53:43 -0500
Received: by mail-wr1-f68.google.com with SMTP id t6so11272610wrr.12
	for <qemu-devel@nongnu.org>; Thu, 17 Jan 2019 06:53:41 -0800 (PST)
Date: Thu, 17 Jan 2019 15:53:37 +0100
From: Stefano Garzarella <sgarzare@redhat.com>
Message-ID: <20190117145337.zz3xi2bav33s67lc@steredhat>
References: <20190117090259.32713-1-sgarzare@redhat.com>
	<20190117090259.32713-6-sgarzare@redhat.com>
	<0bbdcb55-27d9-7098-10f4-aa7aef0a1c24@oracle.com>
	<aa7f4f9e-90b2-c53c-9ddb-b27fd2977d2d@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <aa7f4f9e-90b2-c53c-9ddb-b27fd2977d2d@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from
 fw_cfg
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Liam Merwick <liam.merwick@oracle.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>, Maran Wilson <maran.wilson@oracle.com>, Eduardo Habkost <ehabkost@redhat.com>, Eric Blake <eblake@redhat.com>, Richard Henderson <rth@twiddle.net>, George Kennedy <george.kennedy@oracle.com>, Stefan Hajnoczi <stefanha@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>

On Thu, Jan 17, 2019 at 03:37:24PM +0100, Paolo Bonzini wrote:
> On 17/01/19 15:33, Liam Merwick wrote:
> > #    pc-bios/optionrom/pvh.bin
> > #    pc-bios/optionrom/pvh.img
> > #    pc-bios/optionrom/pvh.raw

Thanks Liam!

> 
> pvh.bin should not be ignored.

I committed pc-bios/pvh.bin, but I think we should ignore the
pc-bios/optionrom/pvh.bin like for the other optionroms (eg.
pc-bios/optionrom/linuxboot_dma.bin is present in .gitignore)

What do you think if I add the following at patch 3/5?

diff --git a/.gitignore b/.gitignore
index 0430257313..321095bf1a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -103,6 +103,10 @@
 /pc-bios/optionrom/linuxboot_dma.bin
 /pc-bios/optionrom/linuxboot_dma.raw
 /pc-bios/optionrom/linuxboot_dma.img
+/pc-bios/optionrom/pvh.asm
+/pc-bios/optionrom/pvh.bin
+/pc-bios/optionrom/pvh.raw
+/pc-bios/optionrom/pvh.img
 /pc-bios/optionrom/multiboot.asm
 /pc-bios/optionrom/multiboot.bin
 /pc-bios/optionrom/multiboot.raw

Thanks,
Stefano