From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, jsnow@redhat.com,
vsementsov@virtuozzo.com, Markus Armbruster <armbru@redhat.com>,
Max Reitz <mreitz@redhat.com>,
"open list:Block layer core" <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/3] block: Expose protocol-specific data to 'qemu-img info'
Date: Thu, 17 Jan 2019 17:39:39 +0100 [thread overview]
Message-ID: <20190117163939.GB6761@localhost.localdomain> (raw)
In-Reply-To: <20190117153321.29749-2-eblake@redhat.com>
Am 17.01.2019 um 16:33 hat Eric Blake geschrieben:
> 'qemu-img info' is useful for showing additional information
> about an image - but sometimes the interesting information is
> specific to the protocol rather than to the format layer. Set
> the groundwork for showing this information; further patches
> will then enable specific pieces of information.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
Isn't this making invalid assumptions about the structure of the block
graph? Who says that I don't have a quorum node below the format layer
with five different protocol layer children? Some of which may have
filter nodes on top?
Kevin
next prev parent reply other threads:[~2019-01-17 16:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 15:33 [Qemu-devel] [RFC PATCH 0/3] Expand 'qemu-img info' to show protocol details Eric Blake
2019-01-17 15:33 ` [Qemu-devel] [PATCH 1/3] block: Expose protocol-specific data to 'qemu-img info' Eric Blake
2019-01-17 16:39 ` Kevin Wolf [this message]
2019-01-17 17:46 ` Eric Blake
2019-01-18 14:20 ` Vladimir Sementsov-Ogievskiy
2019-01-17 15:33 ` [Qemu-devel] [PATCH 2/3] file: Expose some protocol-specific information Eric Blake
2019-01-18 14:08 ` Vladimir Sementsov-Ogievskiy
2019-01-18 16:15 ` Eric Blake
2019-01-17 15:33 ` [Qemu-devel] [PATCH 3/3] RFC: nbd: Expose " Eric Blake
2019-01-17 16:06 ` [Qemu-devel] [RFC PATCH 0/3] Expand 'qemu-img info' to show protocol details Daniel P. Berrangé
2019-01-17 16:15 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190117163939.GB6761@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).