From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>, "Cleber Rosa" <crosa@redhat.com>
Subject: [Qemu-devel] [PULL 3/9] configure: keep track of Python version
Date: Thu, 17 Jan 2019 18:17:37 -0200 [thread overview]
Message-ID: <20190117201743.20470-4-ehabkost@redhat.com> (raw)
In-Reply-To: <20190117201743.20470-1-ehabkost@redhat.com>
From: Cleber Rosa <crosa@redhat.com>
Some functionality is dependent on the Python version
detected/configured on configure. While it's possible to run the
Python version later and check for the version, doing it once is
preferable. Also, it's a relevant information to keep in build logs,
as the overall behavior of the build can be affected by it.
Signed-off-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20181109150710.31085-2-crosa@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
configure | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 3eee3fcf70..ca3d407d75 100755
--- a/configure
+++ b/configure
@@ -1797,6 +1797,9 @@ if ! $python -c 'import sys; sys.exit(sys.version_info < (2,7))'; then
"Use --python=/path/to/python to specify a supported Python."
fi
+# Preserve python version since some functionality is dependent on it
+python_version=$($python -V 2>&1 | sed -e 's/Python\ //')
+
# Suppress writing compiled files
python="$python -B"
@@ -6010,7 +6013,7 @@ echo "LDFLAGS $LDFLAGS"
echo "QEMU_LDFLAGS $QEMU_LDFLAGS"
echo "make $make"
echo "install $install"
-echo "python $python"
+echo "python $python ($python_version)"
if test "$slirp" = "yes" ; then
echo "smbd $smbd"
fi
@@ -6959,6 +6962,7 @@ echo "INSTALL_DATA=$install -c -m 0644" >> $config_host_mak
echo "INSTALL_PROG=$install -c -m 0755" >> $config_host_mak
echo "INSTALL_LIB=$install -c -m 0644" >> $config_host_mak
echo "PYTHON=$python" >> $config_host_mak
+echo "PYTHON_VERSION=$python_version" >> $config_host_mak
echo "CC=$cc" >> $config_host_mak
if $iasl -h > /dev/null 2>&1; then
echo "IASL=$iasl" >> $config_host_mak
--
2.18.0.rc1.1.g3f1ff2140
next prev parent reply other threads:[~2019-01-17 20:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 20:17 [Qemu-devel] [PULL 0/9] Python queue, 2019-01-17 Eduardo Habkost
2019-01-17 20:17 ` [Qemu-devel] [PULL 1/9] scripts/device-crash-test: Remove known crashes Eduardo Habkost
2019-01-17 20:17 ` [Qemu-devel] [PULL 2/9] scripts: Remove unused python imports Eduardo Habkost
2019-01-17 20:17 ` Eduardo Habkost [this message]
2019-01-17 20:17 ` [Qemu-devel] [PULL 4/9] check-venv: use recorded Python version Eduardo Habkost
2019-01-17 20:17 ` [Qemu-devel] [PULL 5/9] Travis CI: make specified Python versions usable on jobs Eduardo Habkost
2019-01-17 20:17 ` [Qemu-devel] [PULL 6/9] check-help: visual and content improvements Eduardo Habkost
2019-01-17 20:17 ` [Qemu-devel] [PULL 7/9] Acceptance tests: add Linux initrd checking test Eduardo Habkost
2019-01-17 20:17 ` [Qemu-devel] [PULL 8/9] qemu.py: Fix error message when qemu dies from signal Eduardo Habkost
2019-01-17 20:17 ` [Qemu-devel] [PULL 9/9] scripts/replay-dump.py: fix utf-8 mangling Eduardo Habkost
2019-01-18 16:55 ` [Qemu-devel] [PULL 0/9] Python queue, 2019-01-17 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190117201743.20470-4-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).