From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>, "Cleber Rosa" <crosa@redhat.com>
Subject: [Qemu-devel] [PULL 4/9] check-venv: use recorded Python version
Date: Thu, 17 Jan 2019 18:17:38 -0200 [thread overview]
Message-ID: <20190117201743.20470-5-ehabkost@redhat.com> (raw)
In-Reply-To: <20190117201743.20470-1-ehabkost@redhat.com>
From: Cleber Rosa <crosa@redhat.com>
The current approach works fine, but it runs Python on every make
command (even if it's not related to the venv usage).
This is just an optimization, and not a change of behavior.
Signed-off-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20181109150710.31085-3-crosa@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
tests/Makefile.include | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index f403a6571d..f8d4399293 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -958,8 +958,7 @@ TESTS_RESULTS_DIR=$(BUILD_DIR)/tests/results
# information please refer to "avocado --help".
AVOCADO_SHOW=none
-PYTHON3 = $(shell $(PYTHON) -c 'import sys; print(1 if sys.version_info >= (3, 0) else 0)')
-ifeq ($(PYTHON3), 1)
+ifneq ($(findstring v2,"v$(PYTHON_VERSION)"),v2)
$(TESTS_VENV_DIR): $(TESTS_VENV_REQ)
$(call quiet-command, \
$(PYTHON) -m venv --system-site-packages $@, \
--
2.18.0.rc1.1.g3f1ff2140
next prev parent reply other threads:[~2019-01-17 20:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 20:17 [Qemu-devel] [PULL 0/9] Python queue, 2019-01-17 Eduardo Habkost
2019-01-17 20:17 ` [Qemu-devel] [PULL 1/9] scripts/device-crash-test: Remove known crashes Eduardo Habkost
2019-01-17 20:17 ` [Qemu-devel] [PULL 2/9] scripts: Remove unused python imports Eduardo Habkost
2019-01-17 20:17 ` [Qemu-devel] [PULL 3/9] configure: keep track of Python version Eduardo Habkost
2019-01-17 20:17 ` Eduardo Habkost [this message]
2019-01-17 20:17 ` [Qemu-devel] [PULL 5/9] Travis CI: make specified Python versions usable on jobs Eduardo Habkost
2019-01-17 20:17 ` [Qemu-devel] [PULL 6/9] check-help: visual and content improvements Eduardo Habkost
2019-01-17 20:17 ` [Qemu-devel] [PULL 7/9] Acceptance tests: add Linux initrd checking test Eduardo Habkost
2019-01-17 20:17 ` [Qemu-devel] [PULL 8/9] qemu.py: Fix error message when qemu dies from signal Eduardo Habkost
2019-01-17 20:17 ` [Qemu-devel] [PULL 9/9] scripts/replay-dump.py: fix utf-8 mangling Eduardo Habkost
2019-01-18 16:55 ` [Qemu-devel] [PULL 0/9] Python queue, 2019-01-17 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190117201743.20470-5-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).