qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>, "Cleber Rosa" <crosa@redhat.com>
Subject: [Qemu-devel] [PULL 6/9] check-help: visual and content improvements
Date: Thu, 17 Jan 2019 18:17:40 -0200	[thread overview]
Message-ID: <20190117201743.20470-7-ehabkost@redhat.com> (raw)
In-Reply-To: <20190117201743.20470-1-ehabkost@redhat.com>

From: Cleber Rosa <crosa@redhat.com>

The "check" target is not a target that will run all other tests
listed, so in order to be accurate it's necessary to list those that
will run.  The same is true for "check-clean".

Then, to give a better visual impression of the differences in the
various targets, let's add empty lines.

Finally, a small (and hopeful) grammar fix from a non-native speaker.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20181109150710.31085-5-crosa@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 tests/Makefile.include | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tests/Makefile.include b/tests/Makefile.include
index f8d4399293..9348451450 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -3,7 +3,8 @@
 check-help:
 	@echo "Regression testing targets:"
 	@echo
-	@echo " $(MAKE) check                Run all tests"
+	@echo " $(MAKE) check                Run unit, qapi-schema, qtest and decodetree"
+	@echo
 	@echo " $(MAKE) check-qtest-TARGET   Run qtest tests for given target"
 	@echo " $(MAKE) check-qtest          Run qtest tests"
 	@echo " $(MAKE) check-unit           Run qobject tests"
@@ -12,12 +13,13 @@ check-help:
 	@echo " $(MAKE) check-block          Run block tests"
 	@echo " $(MAKE) check-tcg            Run TCG tests"
 	@echo " $(MAKE) check-acceptance     Run all acceptance (functional) tests"
+	@echo
 	@echo " $(MAKE) check-report.html    Generates an HTML test report"
 	@echo " $(MAKE) check-venv           Creates a Python venv for tests"
-	@echo " $(MAKE) check-clean          Clean the tests"
+	@echo " $(MAKE) check-clean          Clean the tests and related data"
 	@echo
 	@echo "Please note that HTML reports do not regenerate if the unit tests"
-	@echo "has not changed."
+	@echo "have not changed."
 	@echo
 	@echo "The variable SPEED can be set to control the gtester speed setting."
 	@echo "Default options are -k and (for $(MAKE) V=1) --verbose; they can be"
-- 
2.18.0.rc1.1.g3f1ff2140

  parent reply	other threads:[~2019-01-17 20:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-17 20:17 [Qemu-devel] [PULL 0/9] Python queue, 2019-01-17 Eduardo Habkost
2019-01-17 20:17 ` [Qemu-devel] [PULL 1/9] scripts/device-crash-test: Remove known crashes Eduardo Habkost
2019-01-17 20:17 ` [Qemu-devel] [PULL 2/9] scripts: Remove unused python imports Eduardo Habkost
2019-01-17 20:17 ` [Qemu-devel] [PULL 3/9] configure: keep track of Python version Eduardo Habkost
2019-01-17 20:17 ` [Qemu-devel] [PULL 4/9] check-venv: use recorded " Eduardo Habkost
2019-01-17 20:17 ` [Qemu-devel] [PULL 5/9] Travis CI: make specified Python versions usable on jobs Eduardo Habkost
2019-01-17 20:17 ` Eduardo Habkost [this message]
2019-01-17 20:17 ` [Qemu-devel] [PULL 7/9] Acceptance tests: add Linux initrd checking test Eduardo Habkost
2019-01-17 20:17 ` [Qemu-devel] [PULL 8/9] qemu.py: Fix error message when qemu dies from signal Eduardo Habkost
2019-01-17 20:17 ` [Qemu-devel] [PULL 9/9] scripts/replay-dump.py: fix utf-8 mangling Eduardo Habkost
2019-01-18 16:55 ` [Qemu-devel] [PULL 0/9] Python queue, 2019-01-17 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190117201743.20470-7-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=crosa@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).