From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:45931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkJh7-0000WR-Qd for qemu-devel@nongnu.org; Thu, 17 Jan 2019 21:15:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gkJeT-0007ET-5Q for qemu-devel@nongnu.org; Thu, 17 Jan 2019 21:12:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52578) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gkJeS-0007C7-W5 for qemu-devel@nongnu.org; Thu, 17 Jan 2019 21:12:57 -0500 Date: Thu, 17 Jan 2019 21:12:53 -0500 From: "Michael S. Tsirkin" Message-ID: <20190117211138-mutt-send-email-mst@kernel.org> References: <20190115200252.25911-1-mst@redhat.com> <20190117084350-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PULL v2 00/49] pci, pc, virtio: fixes, features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , imammedo@redhat.com On Thu, Jan 17, 2019 at 04:21:24PM +0000, Peter Maydell wrote: > On Thu, 17 Jan 2019 at 13:44, Michael S. Tsirkin wrote: > > > > On Thu, Jan 17, 2019 at 12:48:22PM +0000, Peter Maydell wrote: > > > This fails 'make check' on s390x host: > > > Oh. I am pretty sure it's endian-ness :( > > > > Any chance you can quickly test the below? > > Yes, that change allows the tests to pass on the s390 box. > > thanks > -- PMM Re-pushed a fixed patch to the same tag. Igor, in the future pls remember to be conscious of size of integers: it's not safe to cast uint32_t* to gsize *! Thanks! -- MST