From: "Singh, Brijesh" <brijesh.singh@amd.com>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"Singh, Brijesh" <brijesh.singh@amd.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH 2/2] target/i386: sev: Do not pin the ram device memory region
Date: Thu, 17 Jan 2019 21:53:16 +0000 [thread overview]
Message-ID: <20190117215300.29694-3-brijesh.singh@amd.com> (raw)
In-Reply-To: <20190117215300.29694-1-brijesh.singh@amd.com>
The RAM device presents a memory region that should be handled
as an IO region and should not be pinned.
In the case of the vfio-pci, RAM device represents a MMIO BAR
and the memory region is not backed by pages hence
KVM_MEMORY_ENCRYPT_REG_REGION fails to lock the memory range.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1667249
Cc: Alex Williamson <alex.williamson@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
---
target/i386/sev.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/target/i386/sev.c b/target/i386/sev.c
index 20b2d325d8..3e9d5c02fa 100644
--- a/target/i386/sev.c
+++ b/target/i386/sev.c
@@ -131,6 +131,17 @@ sev_ram_block_added(RAMBlockNotifier *n, void *host, size_t size)
{
int r;
struct kvm_enc_region range;
+ ram_addr_t offset;
+ MemoryRegion *mr;
+
+ mr = memory_region_from_host(host, &offset);
+ /*
+ * The RAM device presents a memory region that should be treated
+ * as IO region and should not be pinned.
+ */
+ if (memory_region_is_ram_device(mr)) {
+ return;
+ }
range.addr = (__u64)(unsigned long)host;
range.size = size;
--
2.17.1
next prev parent reply other threads:[~2019-01-17 21:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 21:53 [Qemu-devel] [PATCH 0/2] Fix SEV VM device assignment Singh, Brijesh
2019-01-17 21:53 ` [Qemu-devel] [PATCH 1/2] memory: Fix the memory region type assignment order Singh, Brijesh
2019-02-04 17:53 ` Alex Williamson
2019-01-17 21:53 ` Singh, Brijesh [this message]
2019-02-04 17:59 ` [Qemu-devel] [PATCH 2/2] target/i386: sev: Do not pin the ram device memory region Alex Williamson
2019-02-04 21:03 ` Singh, Brijesh
2019-02-04 17:40 ` [Qemu-devel] [PATCH 0/2] Fix SEV VM device assignment Singh, Brijesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190117215300.29694-3-brijesh.singh@amd.com \
--to=brijesh.singh@amd.com \
--cc=alex.williamson@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).