Re: [Qemu-devel] [RFC PATCH v2 23/37] build: convert pci.mak to Kconfig

[Yang Zhong <yang.zhong@intel.com>]

On Wed, Jan 16, 2019 at 12:41:17PM +0100, Thomas Huth wrote:
> 
> The e1000e is a PCI-e device, so maybe this should rather depend on
> "PCIE" instead?
> 
  Thanks Thomas, yes, i will change this.  Yang

> With that fixed:
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> 
> 
> >  config RTL8139_PCI
> >      bool
> > +    default y
> > +    depends on PCI
> >  
> >  config VMXNET3_PCI
> >      bool
> > +    default y
> > +    depends on PCI
> [...]
> > diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
> > index cbf5c5d761..f23c542d27 100644
> > --- a/hw/usb/Kconfig
> > +++ b/hw/usb/Kconfig
> > @@ -3,21 +3,31 @@ config USB
> >  
> >  config USB_UHCI
> >      bool
> > +    default y
> > +    depends on PCI
> >  
> >  config USB_OHCI
> >      bool
> > +    default y
> > +    depends on PCI
> >  
> >  config USB_EHCI
> >      bool
> > +    default y
> > +    depends on PCI
> 
> We might need a USB_EHCI_PCI switch in the future (since there is also
> _SYSBUS which could be used without PCI), but I think that can be done
> in a later patch.
>
   Thanks Thomas, we can put this patch in second stage. Yang
 
>  Thomas