Re: [Qemu-devel] [PATCH] trace: add ability to do simple printf logging via systemtap

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]

On Thu, Jan 17, 2019 at 02:52:07PM +0000, Daniel P. Berrangé wrote:

Dequeued.  I encountered two issues during testing:

1. s/binary/file/ in qemu-trace-stap's which() function:

diff --git a/scripts/qemu-trace-stap b/scripts/qemu-trace-stap
index b2eb41fbb0..3b4ec5e9b9 100755
--- a/scripts/qemu-trace-stap
+++ b/scripts/qemu-trace-stap
@@ -37,7 +37,7 @@ def which(file):
         if os.path.exists(os.path.join(path, file)):
                 return os.path.join(path, file)
 
-    print("Unable to find '%s' in $PATH" % binary)
+    print("Unable to find '%s' in $PATH" % file)
     sys.exit(1)
 
 

2. The tpm_crb_mmio_read trace event's TARGET_FMT_plx format specifier
   macro isn't handled.  stap sees a literal "TARGET_FMT_plx" string and
   reports that the number of format string arguments is incorrect:

   semantic error: Wrong number of args to formatted print operator: identifier 'printf' at :9189:5
   source:     printf("%d@%d tpm_crb_mmio_read CRB read 0x TARGET_FMT_plx  len:%u val: 0x%x\n", pid(), gettimeofday_ns(), addr, size, val)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]