qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] spapr: Forbid setting ic-mode for old machine types
@ 2019-01-17 11:06 Greg Kurz
  2019-01-17 11:58 ` Cédric Le Goater
  2019-01-31 17:47 ` no-reply
  0 siblings, 2 replies; 4+ messages in thread
From: Greg Kurz @ 2019-01-17 11:06 UTC (permalink / raw)
  To: qemu-devel; +Cc: qemu-ppc, David Gibson, Cédric Le Goater

Machine types 3.0 and older only know about the legacy XICS backend.
Make it clear by erroring out if the user tries to set ic-mode on
such machines.

Signed-off-by: Greg Kurz <groug@kaod.org>
---

Motivation for this comes from a failing backward migration test, caused
by ic-mode=xics I forgot to drop from the command line :)
---
 hw/ppc/spapr.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 0942f35bf87e..6b8dbf5c5a3c 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -3126,6 +3126,11 @@ static void spapr_set_ic_mode(Object *obj, const char *value, Error **errp)
 {
     sPAPRMachineState *spapr = SPAPR_MACHINE(obj);
 
+    if (SPAPR_MACHINE_GET_CLASS(spapr)->legacy_irq_allocation) {
+        error_setg(errp, "This machine only uses the legacy XICS backend, don't pass ic-mode");
+        return;
+    }
+
     /* The legacy IRQ backend can not be set */
     if (strcmp(value, "xics") == 0) {
         spapr->irq = &spapr_irq_xics;

^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-31 17:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-17 11:06 [Qemu-devel] [PATCH] spapr: Forbid setting ic-mode for old machine types Greg Kurz
2019-01-17 11:58 ` Cédric Le Goater
2019-01-20 20:29   ` David Gibson
2019-01-31 17:47 ` no-reply

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).