* [Qemu-devel] [PATCH] target/s390x: define TCG_GUEST_DEFAULT_MO for MTTCG
@ 2019-01-18 17:18 Alex Bennée
2019-01-18 17:35 ` David Hildenbrand
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Alex Bennée @ 2019-01-18 17:18 UTC (permalink / raw)
To: qemu-devel
Cc: Alex Bennée, David Hildenbrand, Richard Henderson,
Cornelia Huck, open list:S390
MTTCG should be enabled by default whenever the memory model allows
it. s390x was missing its definition of TCG_GUEST_DEFAULT_MO meaning
the user had to manually specify --accel tcg,thread=multi.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: David Hildenbrand <david@redhat.com>
---
target/s390x/cpu.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h
index 8c2320e882..47d2c2e9cf 100644
--- a/target/s390x/cpu.h
+++ b/target/s390x/cpu.h
@@ -35,6 +35,10 @@
#define CPUArchState struct CPUS390XState
#include "exec/cpu-defs.h"
+
+/* The z/Architecture has a strong memory model with some store-after-load re-ordering */
+#define TCG_GUEST_DEFAULT_MO (TCG_MO_ALL & ~TCG_MO_ST_LD)
+
#define TARGET_PAGE_BITS 12
#define TARGET_PHYS_ADDR_SPACE_BITS 64
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] target/s390x: define TCG_GUEST_DEFAULT_MO for MTTCG
2019-01-18 17:18 [Qemu-devel] [PATCH] target/s390x: define TCG_GUEST_DEFAULT_MO for MTTCG Alex Bennée
@ 2019-01-18 17:35 ` David Hildenbrand
2019-01-18 21:53 ` Richard Henderson
2019-01-21 7:34 ` Cornelia Huck
2 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2019-01-18 17:35 UTC (permalink / raw)
To: Alex Bennée, qemu-devel
Cc: Richard Henderson, Cornelia Huck, open list:S390
On 18.01.19 18:18, Alex Bennée wrote:
> MTTCG should be enabled by default whenever the memory model allows
> it. s390x was missing its definition of TCG_GUEST_DEFAULT_MO meaning
> the user had to manually specify --accel tcg,thread=multi.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: David Hildenbrand <david@redhat.com>
> ---
> target/s390x/cpu.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h
> index 8c2320e882..47d2c2e9cf 100644
> --- a/target/s390x/cpu.h
> +++ b/target/s390x/cpu.h
> @@ -35,6 +35,10 @@
> #define CPUArchState struct CPUS390XState
>
> #include "exec/cpu-defs.h"
> +
> +/* The z/Architecture has a strong memory model with some store-after-load re-ordering */
> +#define TCG_GUEST_DEFAULT_MO (TCG_MO_ALL & ~TCG_MO_ST_LD)
Didn't know this was the way to make it be enabled as default.
As discussed on IRC
Reviewed-by: David Hildenbrand <david@redhat.com>
Thanks!
> +
> #define TARGET_PAGE_BITS 12
>
> #define TARGET_PHYS_ADDR_SPACE_BITS 64
>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] target/s390x: define TCG_GUEST_DEFAULT_MO for MTTCG
2019-01-18 17:18 [Qemu-devel] [PATCH] target/s390x: define TCG_GUEST_DEFAULT_MO for MTTCG Alex Bennée
2019-01-18 17:35 ` David Hildenbrand
@ 2019-01-18 21:53 ` Richard Henderson
2019-01-21 7:34 ` Cornelia Huck
2 siblings, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2019-01-18 21:53 UTC (permalink / raw)
To: Alex Bennée, qemu-devel
Cc: David Hildenbrand, Cornelia Huck, open list:S390
On 1/19/19 4:18 AM, Alex Bennée wrote:
> MTTCG should be enabled by default whenever the memory model allows
> it. s390x was missing its definition of TCG_GUEST_DEFAULT_MO meaning
> the user had to manually specify --accel tcg,thread=multi.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: David Hildenbrand <david@redhat.com>
> ---
> target/s390x/cpu.h | 4 ++++
> 1 file changed, 4 insertions(+)
I thought we had already done this...
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] target/s390x: define TCG_GUEST_DEFAULT_MO for MTTCG
2019-01-18 17:18 [Qemu-devel] [PATCH] target/s390x: define TCG_GUEST_DEFAULT_MO for MTTCG Alex Bennée
2019-01-18 17:35 ` David Hildenbrand
2019-01-18 21:53 ` Richard Henderson
@ 2019-01-21 7:34 ` Cornelia Huck
2 siblings, 0 replies; 4+ messages in thread
From: Cornelia Huck @ 2019-01-21 7:34 UTC (permalink / raw)
To: Alex Bennée
Cc: qemu-devel, David Hildenbrand, Richard Henderson, open list:S390
On Fri, 18 Jan 2019 17:18:48 +0000
Alex Bennée <alex.bennee@linaro.org> wrote:
> MTTCG should be enabled by default whenever the memory model allows
> it. s390x was missing its definition of TCG_GUEST_DEFAULT_MO meaning
> the user had to manually specify --accel tcg,thread=multi.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: David Hildenbrand <david@redhat.com>
> ---
> target/s390x/cpu.h | 4 ++++
> 1 file changed, 4 insertions(+)
Thanks, applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-21 7:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-18 17:18 [Qemu-devel] [PATCH] target/s390x: define TCG_GUEST_DEFAULT_MO for MTTCG Alex Bennée
2019-01-18 17:35 ` David Hildenbrand
2019-01-18 21:53 ` Richard Henderson
2019-01-21 7:34 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).