From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:59070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1glW96-00048J-8U for qemu-devel@nongnu.org; Mon, 21 Jan 2019 04:45:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1glW8r-0001fv-Ku for qemu-devel@nongnu.org; Mon, 21 Jan 2019 04:45:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43452) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1glW8o-0001S1-S9 for qemu-devel@nongnu.org; Mon, 21 Jan 2019 04:45:15 -0500 Date: Mon, 21 Jan 2019 17:35:05 +0800 From: Peter Xu Message-ID: <20190121093505.GA7669@xz-x1> References: <20190116030815.27273-1-peterx@redhat.com> <154805952549.5550.9154893774048296420@2d3111e9616b> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <154805952549.5550.9154893774048296420@2d3111e9616b> Subject: Re: [Qemu-devel] [PATCH v2 0/4] intel_iommu: misc fixes for error exposed after error_report_once() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: fam@euphon.net, mst@redhat.com, jasowang@redhat.com, eric.auger@redhat.com, alex.williamson@redhat.com, pbonzini@redhat.com On Mon, Jan 21, 2019 at 12:32:07AM -0800, no-reply@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20190116030815.27273-1-peterx@redhat.com/ > > > > Hi, > > This series failed the docker-mingw@fedora build test. Please find the testing commands and > their output below. If you have Docker installed, you can probably reproduce it > locally. > > === TEST SCRIPT BEGIN === > #!/bin/bash > time make docker-test-mingw@fedora SHOW_ENV=1 J=14 > === TEST SCRIPT END === > > CC hw/block/pflash_cfi01.o > In function 'acpi_table_install', > inlined from 'acpi_table_add' at /tmp/qemu-test/src/hw/acpi/core.c:296:5: > /tmp/qemu-test/src/hw/acpi/core.c:184:9: error: 'strncpy' specified bound 4 equals destination size [-Werror=stringop-truncation] > strncpy(ext_hdr->sig, hdrs->sig, sizeof ext_hdr->sig); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /tmp/qemu-test/src/hw/acpi/core.c:203:9: error: 'strncpy' specified bound 6 equals destination size [-Werror=stringop-truncation] > strncpy(ext_hdr->oem_id, hdrs->oem_id, sizeof ext_hdr->oem_id); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /tmp/qemu-test/src/hw/acpi/core.c:207:9: error: 'strncpy' specified bound 8 equals destination size [-Werror=stringop-truncation] > strncpy(ext_hdr->oem_table_id, hdrs->oem_table_id, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > sizeof ext_hdr->oem_table_id); > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /tmp/qemu-test/src/hw/acpi/core.c:216:9: error: 'strncpy' specified bound 4 equals destination size [-Werror=stringop-truncation] > strncpy(ext_hdr->asl_compiler_id, hdrs->asl_compiler_id, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > sizeof ext_hdr->asl_compiler_id); > --- > make: *** [/tmp/qemu-test/src/rules.mak:69: hw/acpi/core.o] Error 1 > make: *** Waiting for unfinished jobs.... > /tmp/qemu-test/src/block/sheepdog.c: In function 'find_vdi_name': > /tmp/qemu-test/src/block/sheepdog.c:1239:5: error: 'strncpy' specified bound 256 equals destination size [-Werror=stringop-truncation] > strncpy(buf + SD_MAX_VDI_LEN, tag, SD_MAX_VDI_TAG_LEN); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > make: *** [/tmp/qemu-test/src/rules.mak:69: block/sheepdog.o] Error 1 > /tmp/qemu-test/src/hw/acpi/aml-build.c: In function 'build_header': > /tmp/qemu-test/src/hw/acpi/aml-build.c:1535:9: error: 'strncpy' specified bound 6 equals destination size [-Werror=stringop-truncation] > strncpy((char *)h->oem_id, oem_id, sizeof h->oem_id); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /tmp/qemu-test/src/hw/acpi/aml-build.c:1541:9: error: 'strncpy' specified bound 8 equals destination size [-Werror=stringop-truncation] > strncpy((char *)h->oem_table_id, oem_table_id, sizeof(h->oem_table_id)); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors I'm uncertain about these errors but it seems to be more likely to be caused by some configuration or compiler change instead of the series itself since this series never changed either acpi or sheepdog code. So I'll temporarily ignore them... Regards, -- Peter Xu