From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:50929) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1glXmw-0004Cm-Nr for qemu-devel@nongnu.org; Mon, 21 Jan 2019 06:30:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1glXmv-0007zy-W5 for qemu-devel@nongnu.org; Mon, 21 Jan 2019 06:30:46 -0500 Received: from mga01.intel.com ([192.55.52.88]:30499) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1glXmv-0007gm-Mu for qemu-devel@nongnu.org; Mon, 21 Jan 2019 06:30:45 -0500 Date: Mon, 21 Jan 2019 19:26:51 +0800 From: Yang Zhong Message-ID: <20190121112651.GA19350@yangzhon-Virtual> References: <20190118112410.3010-1-yang.zhong@intel.com> <20190118112410.3010-29-yang.zhong@intel.com> <20190118113051-mutt-send-email-mst@kernel.org> <20190118142758-mutt-send-email-mst@kernel.org> <154d7fa7-6941-2943-6338-a7440487b399@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <154d7fa7-6941-2943-6338-a7440487b399@redhat.com> Subject: Re: [Qemu-devel] [RFC PATCH v3 28/43] hw/pci/Makefile.objs: make pcie configurable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: "Michael S. Tsirkin" , Yang Zhong , "Maydell, Peter" , thuth@redhat.com, ehabkost@redhat.com, qemu-devel@nongnu.org, sameo@linux.intel.com On Mon, Jan 21, 2019 at 11:25:57AM +0100, Paolo Bonzini wrote: > On 18/01/19 20:28, Michael S. Tsirkin wrote: > > OK, and I also think we should rename it PCIE -> PCI_EXPRESS_, this way > > everything PCI starts with PCI. > > I have no preference for PCIE vs. PCI_EXPRESS (PCIE is universally known > and shorter, but it's okay either way), but I agree it makes sense to > rename everything that selects PCIE so that it starts with either PCIE > or PCI_EXPRESS. Yang, can you place a patch to do that before your > series to do the rename? > Hello Paolo, Yes, i can change PCIE to PCI_EXPRESS per Michael's comments. How can i share this patch ?, or i will send this patches with another changes(patch 41) in v4 ? thanks! Regards, Yang > Thanks, > > Paolo