From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:57566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1glYIF-0002Xt-DG for qemu-devel@nongnu.org; Mon, 21 Jan 2019 07:03:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1glYIE-0000AL-GF for qemu-devel@nongnu.org; Mon, 21 Jan 2019 07:03:07 -0500 Date: Mon, 21 Jan 2019 12:02:53 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20190121120252.GB2083@work-vm> References: <20190116113523.9213-1-david@redhat.com> <20190116113523.9213-5-david@redhat.com> <7c7cfe1c-16c6-fe1b-0e9f-796502e75652@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH RFC 04/10] virtio-pmem: Prototype List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand Cc: Eric Blake , qemu-devel@nongnu.org, "Michael S . Tsirkin" , Igor Mammedov , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost , David Gibson , Cornelia Huck , Halil Pasic , Christian Borntraeger , Collin Walling , Markus Armbruster , qemu-ppc@nongnu.org, qemu-s390x@nongnu.org, Pankaj Gupta * David Hildenbrand (david@redhat.com) wrote: > On 16.01.19 15:46, Eric Blake wrote: > > On 1/16/19 5:35 AM, David Hildenbrand wrote: > >> From: Pankaj Gupta > >> > >> This is the current protoype of virtio-pmem. Support will require > >> machine changes for the architectures that will support it, so it will > >> not yet be compiled. > >> > >> TODO: > >> - Use separate struct for tracking requests internally > >> - Move request/response structs to linux headers > >> - Factor out linux header sync > >> - Drop debug printfs > >> > >> Signed-off-by: Pankaj Gupta > >> [ MemoryDevice/MemoryRegion changes, cleanups, addr property "memaddr", > >> split up patches, unplug handler ] > >> Signed-off-by: David Hildenbrand > >> --- > > > >> +++ b/qapi/misc.json > >> @@ -2949,6 +2949,29 @@ > >> } > >> } > >> > >> +## > >> +# @VirtioPMEMDeviceInfo: > >> +# > >> +# VirtioPMEM state information > >> +# > >> +# @id: device's ID > >> +# > >> +# @memaddr: physical address in memory, where device is mapped > >> +# > >> +# @size: size of memory that the device provides > >> +# > >> +# @memdev: memory backend linked with device > >> +# > >> +# Since: 3.1 > > > > Now 4.0 > > > >> +## > >> +{ 'struct': 'VirtioPMEMDeviceInfo', > >> + 'data': { '*id': 'str', > >> + 'memaddr': 'size', > >> + 'size': 'size', > >> + 'memdev': 'str' > >> + } > >> +} > >> + > >> ## > >> # @MemoryDeviceInfo: > >> # > >> @@ -2958,7 +2981,8 @@ > >> ## > >> { 'union': 'MemoryDeviceInfo', > > > > Does this union need a documentation update that virtio-pmem was added > > in 4.0? > > Seems like: > > ## > # @MemoryDeviceInfo: > # > # Union containing information about a memory device > # > # @dimm: Information about a pc-dimm device. > # > # @nvdimm: Information about a nvdimm device. (since 2.12) > # > # @virtio-pmem: Information about a virtio-pmem device. (since 4.0) > # > # Since: 2.1 > ## > > Does not work. > > In file included from /home/dhildenb/git/qemu/qapi/qapi-schema.json:97: > /home/dhildenb/git/qemu/qapi/misc.json:2975: The following documented > members are not in the declaration: dimm, nvdimm, virtio-pmem > > Any idea how to document this correctly? No I don't, but looking at other Union's they only ever seem to document the base members, not the data members, for example see CpuInfo. Dave > -- > > Thanks, > > David / dhildenb -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK