* [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS
@ 2019-01-21 14:48 Anthony PERARD
2019-01-21 15:15 ` Philippe Mathieu-Daudé
2019-01-21 15:17 ` Peter Maydell
0 siblings, 2 replies; 8+ messages in thread
From: Anthony PERARD @ 2019-01-21 14:48 UTC (permalink / raw)
To: qemu-devel
Cc: Stefano Stabellini, Paul Durrant, xen-devel, Anthony PERARD,
Peter Maydell
When Xen is detected via pkg-config, it isn't necessary to modify
LDFLAGS as modifying libs_softmmu is enough.
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
configure | 1 -
1 file changed, 1 deletion(-)
diff --git a/configure b/configure
index 12fd34f30b..98b270974d 100755
--- a/configure
+++ b/configure
@@ -2355,7 +2355,6 @@ if test "$xen" != "no" ; then
fi
QEMU_CFLAGS="$QEMU_CFLAGS $($pkg_config --cflags $xen_pc)"
libs_softmmu="$($pkg_config --libs $xen_pc) $libs_softmmu"
- LDFLAGS="$($pkg_config --libs $xen_pc) $LDFLAGS"
else
xen_libs="-lxenstore -lxenctrl -lxenguest"
--
Anthony PERARD
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS
2019-01-21 14:48 [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS Anthony PERARD
@ 2019-01-21 15:15 ` Philippe Mathieu-Daudé
2019-01-21 15:17 ` Peter Maydell
1 sibling, 0 replies; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-01-21 15:15 UTC (permalink / raw)
To: Anthony PERARD, qemu-devel
Cc: xen-devel, Stefano Stabellini, Paul Durrant, Peter Maydell
On 1/21/19 3:48 PM, Anthony PERARD wrote:
> When Xen is detected via pkg-config, it isn't necessary to modify
> LDFLAGS as modifying libs_softmmu is enough.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
> configure | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/configure b/configure
> index 12fd34f30b..98b270974d 100755
> --- a/configure
> +++ b/configure
> @@ -2355,7 +2355,6 @@ if test "$xen" != "no" ; then
> fi
> QEMU_CFLAGS="$QEMU_CFLAGS $($pkg_config --cflags $xen_pc)"
> libs_softmmu="$($pkg_config --libs $xen_pc) $libs_softmmu"
> - LDFLAGS="$($pkg_config --libs $xen_pc) $LDFLAGS"
> else
>
> xen_libs="-lxenstore -lxenctrl -lxenguest"
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS
2019-01-21 14:48 [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS Anthony PERARD
2019-01-21 15:15 ` Philippe Mathieu-Daudé
@ 2019-01-21 15:17 ` Peter Maydell
2019-01-22 5:40 ` Michael Tokarev
1 sibling, 1 reply; 8+ messages in thread
From: Peter Maydell @ 2019-01-21 15:17 UTC (permalink / raw)
To: Anthony PERARD
Cc: QEMU Developers, Stefano Stabellini, Paul Durrant, open list:X86,
Michael Tokarev
On Mon, 21 Jan 2019 at 14:49, Anthony PERARD <anthony.perard@citrix.com> wrote:
>
> When Xen is detected via pkg-config, it isn't necessary to modify
> LDFLAGS as modifying libs_softmmu is enough.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
> configure | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/configure b/configure
> index 12fd34f30b..98b270974d 100755
> --- a/configure
> +++ b/configure
> @@ -2355,7 +2355,6 @@ if test "$xen" != "no" ; then
> fi
> QEMU_CFLAGS="$QEMU_CFLAGS $($pkg_config --cflags $xen_pc)"
> libs_softmmu="$($pkg_config --libs $xen_pc) $libs_softmmu"
> - LDFLAGS="$($pkg_config --libs $xen_pc) $LDFLAGS"
> else
>
> xen_libs="-lxenstore -lxenctrl -lxenguest"
> --
> Anthony PERARD
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Cc'ing MJT, who first pointed out to me that this bug
was resulting in various binaries like the linux-user ones
getting linked against the Xen libs unnecessarily.
thanks
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS
2019-01-21 15:17 ` Peter Maydell
@ 2019-01-22 5:40 ` Michael Tokarev
2019-01-24 8:45 ` Markus Armbruster
0 siblings, 1 reply; 8+ messages in thread
From: Michael Tokarev @ 2019-01-22 5:40 UTC (permalink / raw)
To: Peter Maydell, Anthony PERARD
Cc: QEMU Developers, Stefano Stabellini, Paul Durrant, open list:X86
21.01.2019 18:17, Peter Maydell wrote:
> On Mon, 21 Jan 2019 at 14:49, Anthony PERARD <anthony.perard@citrix.com> wrote:
>>
>> When Xen is detected via pkg-config, it isn't necessary to modify
>> LDFLAGS as modifying libs_softmmu is enough.
>>
>> Reported-by: Peter Maydell <peter.maydell@linaro.org>
>> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
>> ---
>> configure | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index 12fd34f30b..98b270974d 100755
>> --- a/configure
>> +++ b/configure
>> @@ -2355,7 +2355,6 @@ if test "$xen" != "no" ; then
>> fi
>> QEMU_CFLAGS="$QEMU_CFLAGS $($pkg_config --cflags $xen_pc)"
>> libs_softmmu="$($pkg_config --libs $xen_pc) $libs_softmmu"
>> - LDFLAGS="$($pkg_config --libs $xen_pc) $LDFLAGS"
>> else
>>
>> xen_libs="-lxenstore -lxenctrl -lxenguest"
>> --
>> Anthony PERARD
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> Cc'ing MJT, who first pointed out to me that this bug
> was resulting in various binaries like the linux-user ones
> getting linked against the Xen libs unnecessarily.
Well, at that time I confirmed the patch fixes this issue, and this
is the same change I come across too, and it is already used on Debian.
So
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Revieved-by: Michael Tokarev <mjt@tls.msk.ru>
Thanks,
/mjt
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS
2019-01-22 5:40 ` Michael Tokarev
@ 2019-01-24 8:45 ` Markus Armbruster
2019-01-24 17:40 ` Eric Blake
0 siblings, 1 reply; 8+ messages in thread
From: Markus Armbruster @ 2019-01-24 8:45 UTC (permalink / raw)
To: Michael Tokarev
Cc: Peter Maydell, Anthony PERARD, open list:X86, Stefano Stabellini,
QEMU Developers, Paul Durrant
Michael Tokarev <mjt@tls.msk.ru> writes:
> 21.01.2019 18:17, Peter Maydell wrote:
>> On Mon, 21 Jan 2019 at 14:49, Anthony PERARD <anthony.perard@citrix.com> wrote:
>>>
>>> When Xen is detected via pkg-config, it isn't necessary to modify
>>> LDFLAGS as modifying libs_softmmu is enough.
>>>
>>> Reported-by: Peter Maydell <peter.maydell@linaro.org>
>>> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
>>> ---
>>> configure | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/configure b/configure
>>> index 12fd34f30b..98b270974d 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -2355,7 +2355,6 @@ if test "$xen" != "no" ; then
>>> fi
>>> QEMU_CFLAGS="$QEMU_CFLAGS $($pkg_config --cflags $xen_pc)"
>>> libs_softmmu="$($pkg_config --libs $xen_pc) $libs_softmmu"
>>> - LDFLAGS="$($pkg_config --libs $xen_pc) $LDFLAGS"
>>> else
>>>
>>> xen_libs="-lxenstore -lxenctrl -lxenguest"
>>> --
>>> Anthony PERARD
>>
>> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>>
>> Cc'ing MJT, who first pointed out to me that this bug
>> was resulting in various binaries like the linux-user ones
>> getting linked against the Xen libs unnecessarily.
>
> Well, at that time I confirmed the patch fixes this issue, and this
> is the same change I come across too, and it is already used on Debian.
> So
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> Revieved-by: Michael Tokarev <mjt@tls.msk.ru>
Typo in Reviewed-by.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS
2019-01-24 8:45 ` Markus Armbruster
@ 2019-01-24 17:40 ` Eric Blake
2019-01-24 18:29 ` Peter Maydell
0 siblings, 1 reply; 8+ messages in thread
From: Eric Blake @ 2019-01-24 17:40 UTC (permalink / raw)
To: Markus Armbruster, Michael Tokarev
Cc: Peter Maydell, Stefano Stabellini, QEMU Developers, Paul Durrant,
Anthony PERARD, open list:X86
[-- Attachment #1: Type: text/plain, Size: 418 bytes --]
On 1/24/19 2:45 AM, Markus Armbruster wrote:
>> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
>> Revieved-by: Michael Tokarev <mjt@tls.msk.ru>
>
> Typo in Reviewed-by.
Should we tighten checkpatch.pl to flag suspicious-looking 'xxx-by:'
tags, to catch instances of typos?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS
2019-01-24 17:40 ` Eric Blake
@ 2019-01-24 18:29 ` Peter Maydell
2019-02-04 22:11 ` Eric Blake
0 siblings, 1 reply; 8+ messages in thread
From: Peter Maydell @ 2019-01-24 18:29 UTC (permalink / raw)
To: Eric Blake
Cc: Markus Armbruster, Michael Tokarev, Stefano Stabellini,
QEMU Developers, Paul Durrant, Anthony PERARD, open list:X86
On Thu, 24 Jan 2019 at 17:40, Eric Blake <eblake@redhat.com> wrote:
>
> On 1/24/19 2:45 AM, Markus Armbruster wrote:
>
> >> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> >> Revieved-by: Michael Tokarev <mjt@tls.msk.ru>
> >
> > Typo in Reviewed-by.
>
> Should we tighten checkpatch.pl to flag suspicious-looking 'xxx-by:'
> tags, to catch instances of typos?
Yes, I would vote for having it whitelist the half a dozen
expected ones and complain about the rest. I think we
kind of discussed this in the past...
thanks
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS
2019-01-24 18:29 ` Peter Maydell
@ 2019-02-04 22:11 ` Eric Blake
0 siblings, 0 replies; 8+ messages in thread
From: Eric Blake @ 2019-02-04 22:11 UTC (permalink / raw)
To: Peter Maydell
Cc: Markus Armbruster, Michael Tokarev, Stefano Stabellini,
QEMU Developers, Paul Durrant, Anthony PERARD, open list:X86
[-- Attachment #1: Type: text/plain, Size: 831 bytes --]
On 1/24/19 12:29 PM, Peter Maydell wrote:
> On Thu, 24 Jan 2019 at 17:40, Eric Blake <eblake@redhat.com> wrote:
>>
>> On 1/24/19 2:45 AM, Markus Armbruster wrote:
>>
>>>> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
>>>> Revieved-by: Michael Tokarev <mjt@tls.msk.ru>
>>>
>>> Typo in Reviewed-by.
>>
>> Should we tighten checkpatch.pl to flag suspicious-looking 'xxx-by:'
>> tags, to catch instances of typos?
>
> Yes, I would vote for having it whitelist the half a dozen
> expected ones and complain about the rest. I think we
> kind of discussed this in the past...
I submitted a patch along those lines:
https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg00910.html
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-02-04 22:24 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-21 14:48 [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS Anthony PERARD
2019-01-21 15:15 ` Philippe Mathieu-Daudé
2019-01-21 15:17 ` Peter Maydell
2019-01-22 5:40 ` Michael Tokarev
2019-01-24 8:45 ` Markus Armbruster
2019-01-24 17:40 ` Eric Blake
2019-01-24 18:29 ` Peter Maydell
2019-02-04 22:11 ` Eric Blake
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).