From: Stefan Berger <stefanb@linux.ibm.com>
To: qemu-stable@nongnu.org, mdroth@linux.ibm.com
Cc: qemu-devel@nongnu.org, Stefan Berger <stefanb@linux.ibm.com>
Subject: [Qemu-devel] [PATCH 1/4] tpm: Zero-init structure to avoid uninitialized variables in valgrind log
Date: Mon, 21 Jan 2019 12:07:28 -0500 [thread overview]
Message-ID: <20190121170731.2500692-2-stefanb@linux.ibm.com> (raw)
In-Reply-To: <20190121170731.2500692-1-stefanb@linux.ibm.com>
Zero-init the ptm_loc structure so that we don't have fields that
are not initialised.
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/tpm/tpm_emulator.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/tpm/tpm_emulator.c b/hw/tpm/tpm_emulator.c
index 10bc20dbec..70f4b10284 100644
--- a/hw/tpm/tpm_emulator.c
+++ b/hw/tpm/tpm_emulator.c
@@ -166,6 +166,7 @@ static int tpm_emulator_set_locality(TPMEmulator *tpm_emu, uint8_t locty_number,
trace_tpm_emulator_set_locality(locty_number);
+ memset(&loc, 0, sizeof(loc));
loc.u.req.loc = locty_number;
if (tpm_emulator_ctrlcmd(tpm_emu, CMD_SET_LOCALITY, &loc,
sizeof(loc), sizeof(loc)) < 0) {
--
2.17.2
next prev parent reply other threads:[~2019-01-21 17:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 17:07 [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1) Stefan Berger
2019-01-21 17:07 ` Stefan Berger [this message]
2019-01-21 17:07 ` [Qemu-devel] [PATCH 2/4] tpm: use loop iterator to set sts data field Stefan Berger
2019-01-21 17:07 ` [Qemu-devel] [PATCH 3/4] tpm: Make sure new locality passed to tpm_tis_prep_abort() is valid Stefan Berger
2019-01-21 17:07 ` [Qemu-devel] [PATCH 4/4] tpm: Make sure the locality received from backend " Stefan Berger
2019-01-31 18:10 ` [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1) no-reply
2019-01-31 18:43 ` no-reply
2019-01-31 18:45 ` no-reply
2019-01-31 18:47 ` no-reply
2019-01-31 18:51 ` no-reply
2019-01-31 21:42 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121170731.2500692-2-stefanb@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=mdroth@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).