[Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1)

[Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1)

[Stefan Berger]

Michael,

   please apply the following patches to v3.0.1. They are the equivalent of

git cherry-pick eff1fe
git cherry-pick 6a50bb
git cherry-pick e92b63
git cherry-pick a639f9

Regards,
   Stefan

Prasad J Pandit (1):
  tpm: use loop iterator to set sts data field

Stefan Berger (3):
  tpm: Zero-init structure to avoid uninitialized variables in valgrind
    log
  tpm: Make sure new locality passed to tpm_tis_prep_abort() is valid
  tpm: Make sure the locality received from backend is valid

 hw/tpm/tpm_emulator.c | 1 +
 hw/tpm/tpm_tis.c      | 8 ++++++--
 2 files changed, 7 insertions(+), 2 deletions(-)

-- 
2.17.2

[Qemu-devel] [PATCH 1/4] tpm: Zero-init structure to avoid uninitialized variables in valgrind log

[Stefan Berger]

Zero-init the ptm_loc structure so that we don't have fields that
are not initialised.

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/tpm/tpm_emulator.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/tpm/tpm_emulator.c b/hw/tpm/tpm_emulator.c
index 10bc20dbec..70f4b10284 100644
--- a/hw/tpm/tpm_emulator.c
+++ b/hw/tpm/tpm_emulator.c
@@ -166,6 +166,7 @@ static int tpm_emulator_set_locality(TPMEmulator *tpm_emu, uint8_t locty_number,
 
     trace_tpm_emulator_set_locality(locty_number);
 
+    memset(&loc, 0, sizeof(loc));
     loc.u.req.loc = locty_number;
     if (tpm_emulator_ctrlcmd(tpm_emu, CMD_SET_LOCALITY, &loc,
                              sizeof(loc), sizeof(loc)) < 0) {
-- 
2.17.2

[Qemu-devel] [PATCH 2/4] tpm: use loop iterator to set sts data field

[Stefan Berger]

From: Prasad J Pandit <pjp@fedoraproject.org>

When TIS request is done, set 'sts' data field across all localities.

Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
---
 hw/tpm/tpm_tis.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
index 12f5c9a759..d9322692ee 100644
--- a/hw/tpm/tpm_tis.c
+++ b/hw/tpm/tpm_tis.c
@@ -295,7 +295,7 @@ static void tpm_tis_request_completed(TPMIf *ti, int ret)
 
     if (s->cmd.selftest_done) {
         for (l = 0; l < TPM_TIS_NUM_LOCALITIES; l++) {
-            s->loc[locty].sts |= TPM_TIS_STS_SELFTEST_DONE;
+            s->loc[l].sts |= TPM_TIS_STS_SELFTEST_DONE;
         }
     }
 
-- 
2.17.2

[Qemu-devel] [PATCH 3/4] tpm: Make sure new locality passed to tpm_tis_prep_abort() is valid

[Stefan Berger]

From: Stefan Berger <stefanb@linux.vnet.ibm.com>

Make sure that the new locality passed to tpm_tis_prep_abort()
is valid.

Add a comment to aborting_locty that it may be any locality, including
TPM_TIS_NO_LOCALITY.

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 hw/tpm/tpm_tis.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
index d9322692ee..9a795ce96c 100644
--- a/hw/tpm/tpm_tis.c
+++ b/hw/tpm/tpm_tis.c
@@ -263,7 +263,9 @@ static void tpm_tis_prep_abort(TPMState *s, uint8_t locty, uint8_t newlocty)
 {
     uint8_t busy_locty;
 
-    s->aborting_locty = locty;
+    assert(TPM_TIS_IS_VALID_LOCTY(newlocty));
+
+    s->aborting_locty = locty; /* may also be TPM_TIS_NO_LOCALITY */
     s->next_locty = newlocty;  /* locality after successful abort */
 
     /*
-- 
2.17.2

[Qemu-devel] [PATCH 4/4] tpm: Make sure the locality received from backend is valid

[Stefan Berger]

From: Stefan Berger <stefanb@linux.vnet.ibm.com>

Make sure that the locality passed from the backend to
tpm_tis_request_completed() is valid.

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 hw/tpm/tpm_tis.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
index 9a795ce96c..1554026788 100644
--- a/hw/tpm/tpm_tis.c
+++ b/hw/tpm/tpm_tis.c
@@ -295,6 +295,8 @@ static void tpm_tis_request_completed(TPMIf *ti, int ret)
     uint8_t locty = s->cmd.locty;
     uint8_t l;
 
+    assert(TPM_TIS_IS_VALID_LOCTY(locty));
+
     if (s->cmd.selftest_done) {
         for (l = 0; l < TPM_TIS_NUM_LOCALITIES; l++) {
             s->loc[l].sts |= TPM_TIS_STS_SELFTEST_DONE;
-- 
2.17.2

Re: [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1)

[no-reply]

Patchew URL: https://patchew.org/QEMU/20190121170731.2500692-1-stefanb@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1)
Type: series
Message-id: 20190121170731.2500692-1-stefanb@linux.ibm.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'

=== OUTPUT BEGIN ===
checkpatch.pl: no revisions returned for revlist '1'
=== OUTPUT END ===

Test command exited with code: 255


The full log is available at
http://patchew.org/logs/20190121170731.2500692-1-stefanb@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1)

[no-reply]

Patchew URL: https://patchew.org/QEMU/20190121170731.2500692-1-stefanb@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1)
Type: series
Message-id: 20190121170731.2500692-1-stefanb@linux.ibm.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190121170731.2500692-1-stefanb@linux.ibm.com -> patchew/20190121170731.2500692-1-stefanb@linux.ibm.com
Switched to a new branch 'test'
2ee3ca908c Merge remote-tracking branch 'remotes/kraxel/tags/usb-20190130-pull-request' into staging
dc5e041976 usb-mtp: replace the homebrew write with qemu_write_full
88fa4028c7 usb-mtp: breakup MTP write into smaller chunks
a8f52aa296 usb-mtp: Reallocate buffer in multiples of MTP_WRITE_BUF_SZ
c8647e59bf usb: implement XHCI underrun/overrun events
a7d1054633 usb: XHCI shall not halt isochronous endpoints
51528c361e hw/usb: Fix LGPL information in the file headers
0f69b05cc7 usb: dev-mtp: close fd in usb_mtp_object_readdir()
1a34ece95d usb: assign unique serial numbers to hid devices

=== OUTPUT BEGIN ===
1/8 Checking commit 1a34ece95d33 (usb: assign unique serial numbers to hid devices)
2/8 Checking commit 0f69b05cc77c (usb: dev-mtp: close fd in usb_mtp_object_readdir())
3/8 Checking commit 51528c361e28 (hw/usb: Fix LGPL information in the file headers)
4/8 Checking commit a7d105463360 (usb: XHCI shall not halt isochronous endpoints)
5/8 Checking commit c8647e59bf33 (usb: implement XHCI underrun/overrun events)
ERROR: spaces required around that '-' (ctx:VxV)
#38: FILE: hw/usb/hcd-xhci.c:1960:
+                xhci_event(xhci, &ev, xhci->slots[epctx->slotid-1].intr);
                                                                ^

ERROR: spaces required around that '-' (ctx:VxV)
#47: FILE: hw/usb/hcd-xhci.c:2041:
+    xhci->slots[slotid-1].intr = 0;
                       ^

ERROR: spaces required around that '-' (ctx:VxV)
#66: FILE: hw/usb/hcd-xhci.c:2316:
+        xhci->slots[slotid-1].intr = get_field(islot_ctx[2], TRB_INTR);
                           ^

ERROR: spaces required around that '-' (ctx:VxV)
#67: FILE: hw/usb/hcd-xhci.c:2317:
+        set_field(&slot_ctx[2], xhci->slots[slotid-1].intr, TRB_INTR);
                                                   ^

total: 4 errors, 0 warnings, 48 lines checked

Patch 5/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/8 Checking commit a8f52aa296e7 (usb-mtp: Reallocate buffer in multiples of MTP_WRITE_BUF_SZ)
7/8 Checking commit 88fa4028c720 (usb-mtp: breakup MTP write into smaller chunks)
8/8 Checking commit dc5e0419769e (usb-mtp: replace the homebrew write with qemu_write_full)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190121170731.2500692-1-stefanb@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1)

[no-reply]

Patchew URL: https://patchew.org/QEMU/20190121170731.2500692-1-stefanb@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190121170731.2500692-1-stefanb@linux.ibm.com
Subject: [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1)

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20190121170731.2500692-1-stefanb@linux.ibm.com -> patchew/20190121170731.2500692-1-stefanb@linux.ibm.com
 - [tag update]      patchew/20190128223118.5255-1-richard.henderson@linaro.org -> patchew/20190128223118.5255-1-richard.henderson@linaro.org
Switched to a new branch 'test'
2ee3ca9 Merge remote-tracking branch 'remotes/kraxel/tags/usb-20190130-pull-request' into staging
dc5e041 usb-mtp: replace the homebrew write with qemu_write_full
88fa402 usb-mtp: breakup MTP write into smaller chunks
a8f52aa usb-mtp: Reallocate buffer in multiples of MTP_WRITE_BUF_SZ
c8647e5 usb: implement XHCI underrun/overrun events
a7d1054 usb: XHCI shall not halt isochronous endpoints
51528c3 hw/usb: Fix LGPL information in the file headers
0f69b05 usb: dev-mtp: close fd in usb_mtp_object_readdir()
1a34ece usb: assign unique serial numbers to hid devices

=== OUTPUT BEGIN ===
1/8 Checking commit 1a34ece95d33 (usb: assign unique serial numbers to hid devices)
2/8 Checking commit 0f69b05cc77c (usb: dev-mtp: close fd in usb_mtp_object_readdir())
3/8 Checking commit 51528c361e28 (hw/usb: Fix LGPL information in the file headers)
4/8 Checking commit a7d105463360 (usb: XHCI shall not halt isochronous endpoints)
5/8 Checking commit c8647e59bf33 (usb: implement XHCI underrun/overrun events)
ERROR: spaces required around that '-' (ctx:VxV)
#38: FILE: hw/usb/hcd-xhci.c:1960:
+                xhci_event(xhci, &ev, xhci->slots[epctx->slotid-1].intr);
                                                                ^

ERROR: spaces required around that '-' (ctx:VxV)
#47: FILE: hw/usb/hcd-xhci.c:2041:
+    xhci->slots[slotid-1].intr = 0;
                       ^

ERROR: spaces required around that '-' (ctx:VxV)
#66: FILE: hw/usb/hcd-xhci.c:2316:
+        xhci->slots[slotid-1].intr = get_field(islot_ctx[2], TRB_INTR);
                           ^

ERROR: spaces required around that '-' (ctx:VxV)
#67: FILE: hw/usb/hcd-xhci.c:2317:
+        set_field(&slot_ctx[2], xhci->slots[slotid-1].intr, TRB_INTR);
                                                   ^

total: 4 errors, 0 warnings, 48 lines checked

Patch 5/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/8 Checking commit a8f52aa296e7 (usb-mtp: Reallocate buffer in multiples of MTP_WRITE_BUF_SZ)
7/8 Checking commit 88fa4028c720 (usb-mtp: breakup MTP write into smaller chunks)
8/8 Checking commit dc5e0419769e (usb-mtp: replace the homebrew write with qemu_write_full)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190121170731.2500692-1-stefanb@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1)

[no-reply]

Patchew URL: https://patchew.org/QEMU/20190121170731.2500692-1-stefanb@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1)
Message-id: 20190121170731.2500692-1-stefanb@linux.ibm.com
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20190121170731.2500692-1-stefanb@linux.ibm.com -> patchew/20190121170731.2500692-1-stefanb@linux.ibm.com
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out 'd4e7d7ac663fcb55f1b93575445fcbca372f17a7'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out '9b7ab2fa020341dee8bf9df6c9cf40003e0136df'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out '441a84d3a642a10b948369c63f32367e8ff6395b'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
2ee3ca9 Merge remote-tracking branch 'remotes/kraxel/tags/usb-20190130-pull-request' into staging
dc5e041 usb-mtp: replace the homebrew write with qemu_write_full
88fa402 usb-mtp: breakup MTP write into smaller chunks
a8f52aa usb-mtp: Reallocate buffer in multiples of MTP_WRITE_BUF_SZ
c8647e5 usb: implement XHCI underrun/overrun events
a7d1054 usb: XHCI shall not halt isochronous endpoints
51528c3 hw/usb: Fix LGPL information in the file headers
0f69b05 usb: dev-mtp: close fd in usb_mtp_object_readdir()
1a34ece usb: assign unique serial numbers to hid devices

=== OUTPUT BEGIN ===
1/8 Checking commit 1a34ece95d33 (usb: assign unique serial numbers to hid devices)
2/8 Checking commit 0f69b05cc77c (usb: dev-mtp: close fd in usb_mtp_object_readdir())
3/8 Checking commit 51528c361e28 (hw/usb: Fix LGPL information in the file headers)
4/8 Checking commit a7d105463360 (usb: XHCI shall not halt isochronous endpoints)
5/8 Checking commit c8647e59bf33 (usb: implement XHCI underrun/overrun events)
ERROR: spaces required around that '-' (ctx:VxV)
#38: FILE: hw/usb/hcd-xhci.c:1960:
+                xhci_event(xhci, &ev, xhci->slots[epctx->slotid-1].intr);
                                                                ^

ERROR: spaces required around that '-' (ctx:VxV)
#47: FILE: hw/usb/hcd-xhci.c:2041:
+    xhci->slots[slotid-1].intr = 0;
                       ^

ERROR: spaces required around that '-' (ctx:VxV)
#66: FILE: hw/usb/hcd-xhci.c:2316:
+        xhci->slots[slotid-1].intr = get_field(islot_ctx[2], TRB_INTR);
                           ^

ERROR: spaces required around that '-' (ctx:VxV)
#67: FILE: hw/usb/hcd-xhci.c:2317:
+        set_field(&slot_ctx[2], xhci->slots[slotid-1].intr, TRB_INTR);
                                                   ^

total: 4 errors, 0 warnings, 48 lines checked

Patch 5/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/8 Checking commit a8f52aa296e7 (usb-mtp: Reallocate buffer in multiples of MTP_WRITE_BUF_SZ)
7/8 Checking commit 88fa4028c720 (usb-mtp: breakup MTP write into smaller chunks)
8/8 Checking commit dc5e0419769e (usb-mtp: replace the homebrew write with qemu_write_full)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190121170731.2500692-1-stefanb@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1)

[no-reply]

Patchew URL: https://patchew.org/QEMU/20190121170731.2500692-1-stefanb@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1)
Type: series
Message-id: 20190121170731.2500692-1-stefanb@linux.ibm.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190121170731.2500692-1-stefanb@linux.ibm.com -> patchew/20190121170731.2500692-1-stefanb@linux.ibm.com
Switched to a new branch 'test'
34e5680bef Merge remote-tracking branch 'remotes/kraxel/tags/usb-20190130-pull-request' into staging
8387d5c617 usb-mtp: replace the homebrew write with qemu_write_full
ca70aac48e usb-mtp: breakup MTP write into smaller chunks
c1d948a8f3 usb-mtp: Reallocate buffer in multiples of MTP_WRITE_BUF_SZ
b6ed7ffc92 usb: implement XHCI underrun/overrun events
0cfbf2b7e4 usb: XHCI shall not halt isochronous endpoints
67b463b634 hw/usb: Fix LGPL information in the file headers
f315447337 usb: dev-mtp: close fd in usb_mtp_object_readdir()
d4158454b1 usb: assign unique serial numbers to hid devices

=== OUTPUT BEGIN ===
1/8 Checking commit d4158454b1c1 (usb: assign unique serial numbers to hid devices)
2/8 Checking commit f31544733723 (usb: dev-mtp: close fd in usb_mtp_object_readdir())
3/8 Checking commit 67b463b6342e (hw/usb: Fix LGPL information in the file headers)
4/8 Checking commit 0cfbf2b7e404 (usb: XHCI shall not halt isochronous endpoints)
5/8 Checking commit b6ed7ffc92a8 (usb: implement XHCI underrun/overrun events)
ERROR: spaces required around that '-' (ctx:VxV)
#39: FILE: hw/usb/hcd-xhci.c:1960:
+                xhci_event(xhci, &ev, xhci->slots[epctx->slotid-1].intr);
                                                                ^

ERROR: spaces required around that '-' (ctx:VxV)
#48: FILE: hw/usb/hcd-xhci.c:2041:
+    xhci->slots[slotid-1].intr = 0;
                       ^

ERROR: spaces required around that '-' (ctx:VxV)
#67: FILE: hw/usb/hcd-xhci.c:2316:
+        xhci->slots[slotid-1].intr = get_field(islot_ctx[2], TRB_INTR);
                           ^

ERROR: spaces required around that '-' (ctx:VxV)
#68: FILE: hw/usb/hcd-xhci.c:2317:
+        set_field(&slot_ctx[2], xhci->slots[slotid-1].intr, TRB_INTR);
                                                   ^

total: 4 errors, 0 warnings, 48 lines checked

Patch 5/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/8 Checking commit c1d948a8f35e (usb-mtp: Reallocate buffer in multiples of MTP_WRITE_BUF_SZ)
7/8 Checking commit ca70aac48e0d (usb-mtp: breakup MTP write into smaller chunks)
8/8 Checking commit 8387d5c6178c (usb-mtp: replace the homebrew write with qemu_write_full)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190121170731.2500692-1-stefanb@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1)

[Stefan Berger]

On 1/31/19 1:51 PM, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20190121170731.2500692-1-stefanb@linux.ibm.com/


Seems unrelated to the series I sent...