From: Caio Carrara <ccarrara@redhat.com>
To: Cleber Rosa <crosa@redhat.com>
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Stefan Markovic" <smarkovic@wavecomp.com>,
"Aleksandar Markovic" <amarkovic@wavecomp.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-s390x@nongnu.org, "Aurelien Jarno" <aurelien@aurel32.net>,
"Cornelia Huck" <cohuck@redhat.com>, "Fam Zheng" <fam@euphon.net>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Aleksandar Rikalo" <arikalo@wavecomp.com>
Subject: Re: [Qemu-devel] [PATCH 03/18] Acceptance tests: improve docstring on pick_default_qemu_bin()
Date: Mon, 21 Jan 2019 18:20:47 -0200 [thread overview]
Message-ID: <20190121202045.GC17671@localhost.localdomain> (raw)
In-Reply-To: <20190117185628.21862-4-crosa@redhat.com>
On Thu, Jan 17, 2019 at 01:56:13PM -0500, Cleber Rosa wrote:
> Making it clear what is returned by this utility function.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Caio Carrara <ccarrara@redhat.com>
> ---
> tests/acceptance/avocado_qemu/__init__.py | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py
> index 1e54fd5932..d8d5b48dac 100644
> --- a/tests/acceptance/avocado_qemu/__init__.py
> +++ b/tests/acceptance/avocado_qemu/__init__.py
> @@ -27,6 +27,10 @@ def pick_default_qemu_bin():
> """
> Picks the path of a QEMU binary, starting either in the current working
> directory or in the source tree root directory.
> +
> + :returns: the path to the default QEMU binary or None if one could not
> + be found
> + :rtype: str or None
> """
> arch = os.uname()[4]
> qemu_bin_relative_path = os.path.join("%s-softmmu" % arch,
> --
> 2.20.1
>
--
Caio Carrara
Software Engineer, Virt Team - Red Hat
ccarrara@redhat.com
next prev parent reply other threads:[~2019-01-21 20:31 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 18:56 [Qemu-devel] [PATCH 00/18] Acceptance Tests: target architecture support Cleber Rosa
2019-01-17 18:56 ` [Qemu-devel] [PATCH 01/18] scripts/qemu.py: log QEMU launch command line Cleber Rosa
2019-01-21 20:19 ` Caio Carrara
2019-01-22 9:47 ` Philippe Mathieu-Daudé
2019-01-22 11:17 ` Alex Bennée
2019-01-17 18:56 ` [Qemu-devel] [PATCH 02/18] Acceptance tests: show avocado test execution by default Cleber Rosa
2019-01-21 20:20 ` Caio Carrara
2019-01-22 9:50 ` Philippe Mathieu-Daudé
2019-01-22 11:19 ` Alex Bennée
2019-01-17 18:56 ` [Qemu-devel] [PATCH 03/18] Acceptance tests: improve docstring on pick_default_qemu_bin() Cleber Rosa
2019-01-21 20:20 ` Caio Carrara [this message]
2019-01-17 18:56 ` [Qemu-devel] [PATCH 04/18] Acceptance tests: fix doc reference to avocado_qemu directory Cleber Rosa
2019-01-21 20:21 ` Caio Carrara
2019-01-22 9:51 ` Philippe Mathieu-Daudé
2019-01-17 18:56 ` [Qemu-devel] [PATCH 05/18] Acceptance tests: introduce arch parameter and attribute Cleber Rosa
2019-01-18 14:28 ` Caio Carrara
2019-01-22 9:54 ` Philippe Mathieu-Daudé
2019-01-30 21:49 ` Cleber Rosa
2019-01-30 21:59 ` Cleber Rosa
2019-01-31 13:55 ` Wainer dos Santos Moschetta
2019-01-31 19:01 ` Cleber Rosa
2019-01-17 18:56 ` [Qemu-devel] [PATCH 06/18] Acceptance tests: use "arch:" tag to filter target specific tests Cleber Rosa
2019-01-18 10:38 ` Cornelia Huck
2019-01-30 22:15 ` Cleber Rosa
2019-01-21 20:24 ` Caio Carrara
2019-01-17 18:56 ` [Qemu-devel] [PATCH 07/18] Acceptance tests: look for target architecture in test tags first Cleber Rosa
2019-01-21 20:25 ` Caio Carrara
2019-01-17 18:56 ` [Qemu-devel] [PATCH 08/18] Boot Linux Console Test: rename the x86_64 after the arch and machine Cleber Rosa
2019-01-21 20:26 ` Caio Carrara
2019-01-22 9:56 ` Philippe Mathieu-Daudé
2019-01-17 18:56 ` [Qemu-devel] [PATCH 09/18] Boot Linux Console Test: update the x86_64 kernel Cleber Rosa
2019-01-21 20:27 ` Caio Carrara
2019-01-17 18:56 ` [Qemu-devel] [PATCH 10/18] Boot Linux Console Test: refactor the console watcher into utility method Cleber Rosa
2019-01-21 20:28 ` Caio Carrara
2019-01-22 10:06 ` Philippe Mathieu-Daudé
2019-01-31 0:17 ` Cleber Rosa
2019-01-31 17:46 ` Wainer dos Santos Moschetta
2019-01-31 19:29 ` Cleber Rosa
2019-01-17 18:56 ` [Qemu-devel] [PATCH 11/18] scripts/qemu.py: support adding a console with the default serial device Cleber Rosa
2019-01-21 20:29 ` Caio Carrara
2019-01-31 18:49 ` Wainer dos Santos Moschetta
2019-01-31 20:05 ` Cleber Rosa
2019-01-17 18:56 ` [Qemu-devel] [PATCH 12/18] Boot Linux Console Test: add a test for mips + malta Cleber Rosa
2019-01-21 20:30 ` Caio Carrara
2019-01-22 10:16 ` Philippe Mathieu-Daudé
2019-01-31 0:27 ` Cleber Rosa
2019-01-17 18:56 ` [Qemu-devel] [PATCH 13/18] Boot Linux Console Test: add a test for mips64el " Cleber Rosa
2019-01-21 20:31 ` Caio Carrara
2019-01-22 10:19 ` Philippe Mathieu-Daudé
2019-01-31 1:26 ` Cleber Rosa
2019-01-31 10:24 ` Philippe Mathieu-Daudé
2019-01-22 10:57 ` Philippe Mathieu-Daudé
2019-01-31 1:34 ` Cleber Rosa
2019-01-31 10:26 ` Philippe Mathieu-Daudé
2019-01-31 15:06 ` Cleber Rosa
2019-01-31 18:14 ` Wainer dos Santos Moschetta
2019-01-31 20:11 ` Cleber Rosa
2019-01-17 18:56 ` [Qemu-devel] [PATCH 14/18] Boot Linux Console Test: add a test for ppc64 + pseries Cleber Rosa
2019-01-21 20:32 ` Caio Carrara
2019-01-22 16:07 ` Alex Bennée
2019-01-31 2:37 ` Cleber Rosa
2019-01-31 10:23 ` Philippe Mathieu-Daudé
2019-01-17 18:56 ` [Qemu-devel] [PATCH 15/18] Boot Linux Console Test: add a test for aarch64 + virt Cleber Rosa
2019-01-21 20:32 ` Caio Carrara
2019-01-31 20:02 ` Wainer dos Santos Moschetta
2019-01-31 20:21 ` Cleber Rosa
2019-01-31 21:26 ` Cleber Rosa
2019-02-01 16:10 ` Cleber Rosa
2019-06-07 3:26 ` Eduardo Habkost
2019-06-07 3:42 ` Eduardo Habkost
2019-06-07 15:44 ` Cleber Rosa
2019-06-07 18:58 ` Eduardo Habkost
2019-06-10 8:53 ` Daniel P. Berrangé
2019-06-10 16:50 ` Cleber Rosa
2019-06-07 7:41 ` Laszlo Ersek
2019-06-07 15:33 ` Cleber Rosa
2019-01-17 18:56 ` [Qemu-devel] [PATCH 16/18] Boot Linux Console Test: add a test for arm " Cleber Rosa
2019-01-21 20:33 ` Caio Carrara
2019-01-17 18:56 ` [Qemu-devel] [PATCH 17/18] Boot Linux Console Test: add a test for s390x + s390-ccw-virtio Cleber Rosa
2019-01-18 8:58 ` Cornelia Huck
2019-01-18 13:45 ` Cleber Rosa
2019-01-21 20:34 ` Caio Carrara
2019-01-17 18:56 ` [Qemu-devel] [PATCH 18/18] Boot Linux Console Test: add a test for alpha + clipper Cleber Rosa
2019-01-21 20:34 ` Caio Carrara
2019-01-22 10:52 ` Philippe Mathieu-Daudé
2019-01-31 2:53 ` Cleber Rosa
2019-01-31 10:30 ` Philippe Mathieu-Daudé
2019-01-31 20:23 ` Cleber Rosa
2019-01-21 22:15 ` [Qemu-devel] [PATCH 00/18] Acceptance Tests: target architecture support Aleksandar Markovic
2019-01-22 10:48 ` Philippe Mathieu-Daudé
2019-01-31 15:01 ` Cleber Rosa
2019-02-01 5:32 ` Aleksandar Markovic
2019-02-01 16:17 ` Cleber Rosa
2019-01-31 18:09 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121202045.GC17671@localhost.localdomain \
--to=ccarrara@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=amarkovic@wavecomp.com \
--cc=arikalo@wavecomp.com \
--cc=aurelien@aurel32.net \
--cc=cohuck@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=smarkovic@wavecomp.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).