From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:43828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm12c-0002Yn-Ge for qemu-devel@nongnu.org; Tue, 22 Jan 2019 13:45:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm12W-0003bj-4n for qemu-devel@nongnu.org; Tue, 22 Jan 2019 13:44:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59214) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gm12V-0003MC-P1 for qemu-devel@nongnu.org; Tue, 22 Jan 2019 13:44:47 -0500 Date: Tue, 22 Jan 2019 08:55:38 -0500 From: "Michael S. Tsirkin" Message-ID: <20190122085519-mutt-send-email-mst@kernel.org> References: <20190121181030.2112-1-philmd@redhat.com> <76c2912b-8c50-d15f-f153-e80fa4b1be6e@redhat.com> <5f27ba6f-f2e3-423f-54ee-0f6d6a0e1b48@redhat.com> <20190122000452-mutt-send-email-mst@kernel.org> <407faf62-ad6e-c846-05aa-beafb3da0c14@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <407faf62-ad6e-c846-05aa-beafb3da0c14@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] virtio-net: Fix VirtIONet typedef redefinition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eric Blake , qemu-devel@nongnu.org, Peter Maydell , Yuri Benditovich , Wei Xu On Tue, Jan 22, 2019 at 06:23:34AM +0100, Thomas Huth wrote: > On 2019-01-22 06:05, Michael S. Tsirkin wrote: > > On Tue, Jan 22, 2019 at 05:28:12AM +0100, Thomas Huth wrote: > >> On 2019-01-21 20:46, Philippe Mathieu-Daud=E9 wrote: > >>> On 1/21/19 8:22 PM, Eric Blake wrote: > >>>> On 1/21/19 12:10 PM, Philippe Mathieu-Daud=E9 wrote: > >>>>> Commit 2974e916df8 introduced the VirtioNetRscChain structure whi= ch > >>>>> refer to a VirtIONet, declared later, thus required VirtIONet typ= edef > >>>>> to be declarated forward. > >>>> > >>>> s/be declarated forward/use a forward declaration/ > >>> > >>> Thanks Eric. > >>> > >>> Thomas, do you mind fixing this if you take this patch? > >> > >> No problem, just fixed it while picking up the patch. > >=20 > > I'm not sure why it's going through that tree but sure go ahead. >=20 > Sorry, I certainly don't want to step on your toes here. I just need > this patch to fix compilation with "-std=3Dgnu99" which is required for > the patch in my PULL request that enables this compiler flag there: >=20 > https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg02695.html Oh. Your tree makes sense then. > > Sent Reviewed-by tag. >=20 > Thanks a lot! >=20 > Thomas