From: "Richard W.M. Jones" <rjones@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org, Christophe Fergeau <cfergeau@redhat.com>,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating
Date: Tue, 22 Jan 2019 11:18:21 +0000 [thread overview]
Message-ID: <20190122111821.GA18917@redhat.com> (raw)
In-Reply-To: <87o98sii5b.fsf@dusky.pond.sub.org>
On Mon, Jan 07, 2019 at 04:47:44PM +0100, Markus Armbruster wrote:
> Eric Blake <eblake@redhat.com> writes:
>
> > On 1/2/19 12:01 PM, Christophe Fergeau wrote:
> >> Adding Markus to cc: list, I forgot to do it when sending the patch.
> >
> > Also worth backporting via qemu-stable, now in cc.
> >
> >>
> >> Christophe
> >>
> >> On Wed, Jan 02, 2019 at 03:05:35PM +0100, Christophe Fergeau wrote:
> >>> commit 8bca4613 added support for %% in json strings when interpolating,
> >>> but in doing so, this broke handling of % when not interpolating as the
> >>> '%' is skipped in both cases.
> >>> This commit ensures we only try to handle %% when interpolating.
>
> Impact?
>
> If you're unable to assess, could you give us at least a reproducer?
This affects the block/curl.c driver. Here's a simple reproducer:
https://bugzilla.redhat.com/show_bug.cgi?id=1668244#c3
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW
next prev parent reply other threads:[~2019-01-22 11:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 14:05 [Qemu-devel] [PATCH] json: Fix % handling when not interpolating Christophe Fergeau
2019-01-02 18:01 ` Christophe Fergeau
2019-01-02 22:08 ` Eric Blake
2019-01-07 15:47 ` Markus Armbruster
2019-01-07 16:26 ` Eric Blake
2019-01-07 16:36 ` Christophe Fergeau
2019-01-08 10:36 ` Markus Armbruster
2019-01-09 13:06 ` Max Reitz
2019-01-09 14:32 ` Markus Armbruster
2019-01-09 14:41 ` Max Reitz
2019-01-09 16:20 ` Markus Armbruster
2019-01-09 16:29 ` Max Reitz
2019-01-09 14:49 ` Daniel P. Berrangé
2019-01-09 15:02 ` Max Reitz
2019-01-09 16:55 ` Daniel P. Berrangé
2019-01-10 9:30 ` Markus Armbruster
2019-01-22 11:18 ` Richard W.M. Jones [this message]
2019-01-24 9:35 ` Markus Armbruster
2019-01-24 12:39 ` Christophe Fergeau
2019-01-24 18:13 ` Eric Blake
2019-01-24 18:29 ` Markus Armbruster
2019-01-24 19:55 ` Eric Blake
2019-01-22 11:21 ` Richard W.M. Jones
2019-01-24 14:37 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122111821.GA18917@redhat.com \
--to=rjones@redhat.com \
--cc=armbru@redhat.com \
--cc=cfergeau@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).