From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:48181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm167-0005Wr-3w for qemu-devel@nongnu.org; Tue, 22 Jan 2019 13:48:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm15j-000640-80 for qemu-devel@nongnu.org; Tue, 22 Jan 2019 13:48:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44494) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gm15i-000612-Ua for qemu-devel@nongnu.org; Tue, 22 Jan 2019 13:48:07 -0500 From: "Dr. David Alan Gilbert (git)" Date: Tue, 22 Jan 2019 17:31:11 +0000 Message-Id: <20190122173111.29821-1-dgilbert@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH] migration/rdma: unegister fd handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, jemmy858585@gmail.com, quintela@redhat.com, peterx@redhat.com From: "Dr. David Alan Gilbert" Unregister the fd handler before we destroy the channel, otherwise we've got a race where we might land in the fd handler just as we're closing the device. (The race is quite data dependent, you just have to have the right set of devices for it to trigger). Corresponds to RH bz: https://bugzilla.redhat.com/show_bug.cgi?id=3D16666= 01 Signed-off-by: Dr. David Alan Gilbert --- migration/rdma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/rdma.c b/migration/rdma.c index 9b2e7e10aa..54a3c11540 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -2321,6 +2321,7 @@ static void qemu_rdma_cleanup(RDMAContext *rdma) rdma->connected =3D false; } =20 + qemu_set_fd_handler(rdma->channel->fd, NULL, NULL, NULL); g_free(rdma->dest_blocks); rdma->dest_blocks =3D NULL; =20 --=20 2.20.1