From: Max Filippov <jcmvbkbc@gmail.com>
To: qemu-devel@nongnu.org
Cc: Max Filippov <jcmvbkbc@gmail.com>
Subject: [Qemu-devel] [PATCH] target/xtensa: add qemu_cpu_kick to xtensa_runstall
Date: Tue, 22 Jan 2019 13:25:04 -0800 [thread overview]
Message-ID: <20190122212504.6137-1-jcmvbkbc@gmail.com> (raw)
When xtensa_runstall is called to unstall a core it needs to kick it
after clearing runstall flag, otherwise the core doesn't start
immediately. There's also no point in clearing CPU_INTERRUPT_HALT, drop
it.
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
target/xtensa/helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/xtensa/helper.c b/target/xtensa/helper.c
index 323c47a7fb54..bcf2f20d4858 100644
--- a/target/xtensa/helper.c
+++ b/target/xtensa/helper.c
@@ -252,7 +252,7 @@ void xtensa_runstall(CPUXtensaState *env, bool runstall)
if (runstall) {
cpu_interrupt(cpu, CPU_INTERRUPT_HALT);
} else {
- cpu_reset_interrupt(cpu, CPU_INTERRUPT_HALT);
+ qemu_cpu_kick(cpu);
}
}
#endif
--
2.11.0
reply other threads:[~2019-01-22 21:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122212504.6137-1-jcmvbkbc@gmail.com \
--to=jcmvbkbc@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).