qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Peter Maydell" <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PATCH v3 08/11] include/fpu/softfloat: Fix compilation with Clang on s390x
Date: Tue, 22 Jan 2019 21:50:13 +0000	[thread overview]
Message-ID: <20190122215016.18697-9-alex.bennee@linaro.org> (raw)
In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org>

From: Thomas Huth <thuth@redhat.com>

Clang v7.0.1 does not like the __int128 variable type for inline
assembly on s390x:

In file included from fpu/softfloat.c:97:
include/fpu/softfloat-macros.h:647:9: error: inline asm error:
 This value type register class is not natively supported!
    asm("dlgr %0, %1" : "+r"(n) : "r"(d));
        ^

Disable this code part there now when compiling with Clang, so that
the generic code gets used instead.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Acked-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 include/fpu/softfloat-macros.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/fpu/softfloat-macros.h b/include/fpu/softfloat-macros.h
index b1d772e6d4..bd5b6418e3 100644
--- a/include/fpu/softfloat-macros.h
+++ b/include/fpu/softfloat-macros.h
@@ -641,7 +641,7 @@ static inline uint64_t udiv_qrnnd(uint64_t *r, uint64_t n1,
     uint64_t q;
     asm("divq %4" : "=a"(q), "=d"(*r) : "0"(n0), "1"(n1), "rm"(d));
     return q;
-#elif defined(__s390x__)
+#elif defined(__s390x__) && !defined(__clang__)
     /* Need to use a TImode type to get an even register pair for DLGR.  */
     unsigned __int128 n = (unsigned __int128)n1 << 64 | n0;
     asm("dlgr %0, %1" : "+r"(n) : "r"(d));
-- 
2.17.1

  parent reply	other threads:[~2019-01-22 21:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-22 21:50 [Qemu-devel] [PATCH v3 00/11] current fpu/next queue (tests & build fix) Alex Bennée
2019-01-22 21:50 ` [Qemu-devel] [PATCH v3 01/11] fp-bench: fix update_random_ops Alex Bennée
2019-01-22 21:50 ` [Qemu-devel] [PATCH v3 02/11] fp-bench: remove wrong exponent raise in fill_random Alex Bennée
2019-01-22 21:50 ` [Qemu-devel] [PATCH v3 03/11] berkeley-testfloat-3: pull changes Alex Bennée
2019-01-22 21:50 ` [Qemu-devel] [PATCH v3 04/11] tests/fp/Makefile: do not use gcc-only -W flags Alex Bennée
2019-01-22 21:50 ` [Qemu-devel] [PATCH v3 05/11] fp-test: fix signature of slow_clear_flags and qemu_clear_flags Alex Bennée
2019-01-22 21:50 ` [Qemu-devel] [PATCH v3 06/11] tests/fp/platform.h: include config-host.h Alex Bennée
2019-01-22 21:50 ` [Qemu-devel] [PATCH v3 07/11] softfloat: enforce softfloat if the host's FMA is broken Alex Bennée
2019-01-22 21:50 ` Alex Bennée [this message]
2019-01-22 21:50 ` [Qemu-devel] [PATCH v3 09/11] tests/Makefile: add floating point tests Alex Bennée
2019-01-22 23:45   ` Emilio G. Cota
2019-01-22 21:50 ` [Qemu-devel] [PATCH v3 10/11] scripts/archive-source: include softfloat tests Alex Bennée
2019-01-22 21:50 ` [Qemu-devel] [PATCH v3 11/11] tests/Makfile: add check-softfloat rule Alex Bennée
2019-01-22 23:46   ` Emilio G. Cota
2019-01-31 17:56 ` [Qemu-devel] [PATCH v3 00/11] current fpu/next queue (tests & build fix) no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190122215016.18697-9-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).