qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Yang Zhong <yang.zhong@intel.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, thuth@redhat.com, peter.maydell@linaro.org,
	ehabkost@redhat.com, sameo@linux.intel.com, yang.zhong@intel.com
Subject: [Qemu-devel] [RFC PATCH v4 23/44] minikconfig: add AST
Date: Wed, 23 Jan 2019 14:55:57 +0800	[thread overview]
Message-ID: <20190123065618.3520-24-yang.zhong@intel.com> (raw)
In-Reply-To: <20190123065618.3520-1-yang.zhong@intel.com>

From: Paolo Bonzini <pbonzini@redhat.com>

Add Python classes that represent the Kconfig abstract syntax tree.
The abstract syntax tree is stored as a list of clauses.  For example:

    config FOO
        depends on BAR
        select BAZ

is represented as three clauses:

    FOO depends on BAR
    FOO default n
    select BAZ if FOO

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 scripts/minikconf.py | 116 ++++++++++++++++++++++++++++++++++++-------
 1 file changed, 98 insertions(+), 18 deletions(-)

diff --git a/scripts/minikconf.py b/scripts/minikconf.py
index fb39e35d6a..a6a28c9c47 100644
--- a/scripts/minikconf.py
+++ b/scripts/minikconf.py
@@ -26,11 +26,84 @@ __all__ = [ 'KconfigParserError', 'KconfigData', 'KconfigParser' ]
 # -------------------------------------------
 
 class KconfigData:
+    class Expr:
+        def __and__(self, rhs):
+            return KconfigData.AND(self, rhs)
+        def __or__(self, rhs):
+            return KconfigData.OR(self, rhs)
+        def __invert__(self):
+            return KconfigData.NOT(self)
+
+    class AND(Expr):
+        def __init__(self, lhs, rhs):
+            self.lhs = lhs
+            self.rhs = rhs
+        def __str__(self):
+            return "(%s && %s)" % (self.lhs, self.rhs)
+
+    class OR(Expr):
+        def __init__(self, lhs, rhs):
+            self.lhs = lhs
+            self.rhs = rhs
+        def __str__(self):
+            return "(%s || %s)" % (self.lhs, self.rhs)
+
+    class NOT(Expr):
+        def __init__(self, lhs):
+            self.lhs = lhs
+        def __str__(self):
+            return "!%s" % (self.lhs)
+
+    class Var(Expr):
+        def __init__(self, name):
+            self.name = name
+            self.value = None
+        def __str__(self):
+            return self.name
+
+    class Clause:
+        def __init__(self, dest):
+            self.dest = dest
+
+    class AssignmentClause(Clause):
+        def __init__(self, dest, value):
+            KconfigData.Clause.__init__(self, dest)
+            self.value = value
+        def __str__(self):
+            return "%s=%s" % (self.dest, 'y' if self.value else 'n')
+
+    class DefaultClause(Clause):
+        def __init__(self, dest, value, cond=None):
+            KconfigData.Clause.__init__(self, dest)
+            self.value = value
+            self.cond = cond
+        def __str__(self):
+            value = 'y' if self.value else 'n'
+            if self.cond is None:
+                return "config %s default %s" % (self.dest, value)
+            else:
+                return "config %s default %s if %s" % (self.dest, value, self.cond)
+
+    class DependsOnClause(Clause):
+        def __init__(self, dest, expr):
+            KconfigData.Clause.__init__(self, dest)
+            self.expr = expr
+        def __str__(self):
+            return "config %s depends on %s" % (self.dest, self.expr)
+
+    class SelectClause(Clause):
+        def __init__(self, dest, cond):
+            KconfigData.Clause.__init__(self, dest)
+            self.cond = cond
+        def __str__(self):
+            return "select %s if %s" % (self.dest, self.cond)
+
     def __init__(self):
         self.previously_included = []
         self.incl_info = None
         self.defined_vars = set()
-        self.referenced_vars = set()
+        self.referenced_vars = dict()
+        self.clauses = list()
 
     # semantic analysis -------------
 
@@ -48,26 +121,28 @@ class KconfigData:
         if (var in self.defined_vars):
             raise Exception('variable "' + var + '" defined twice')
 
-        self.defined_vars.add(var)
+        self.defined_vars.add(var.name)
 
     # var is a string with the variable's name.
-    #
-    # For now this just returns the variable's name itself.
     def do_var(self, var):
-        self.referenced_vars.add(var)
-        return var
+        if (var in self.referenced_vars):
+            return self.referenced_vars[var]
+
+        var_obj = self.referenced_vars[var] = KconfigData.Var(var)
+        return var_obj
 
     def do_assignment(self, var, val):
-        pass
+        self.clauses.append(KconfigData.AssignmentClause(var, val))
 
     def do_default(self, var, val, cond=None):
-        pass
+        self.clauses.append(KconfigData.DefaultClause(var, val, cond))
 
     def do_depends_on(self, var, expr):
-        pass
+        self.clauses.append(KconfigData.DependsOnClause(var, expr))
 
     def do_select(self, var, symbol, cond=None):
-        pass
+        cond = (cond & var) if cond is not None else var
+        self.clauses.append(KconfigData.SelectClause(symbol, cond))
 
 # -------------------------------------------
 # KconfigParser implements a recursive descent parser for (simplified)
@@ -227,31 +302,34 @@ class KconfigParser:
     def parse_primary(self):
         if self.tok == TOK_NOT:
             self.get_token()
-            self.parse_primary()
+            val = ~self.parse_primary()
         elif self.tok == TOK_LPAREN:
             self.get_token()
-            self.parse_expr()
+            val = self.parse_expr()
             if self.tok != TOK_RPAREN:
                 raise KconfigParserError(self, 'Expected ")"')
             self.get_token()
         elif self.tok == TOK_ID:
-            self.parse_var()
+            val = self.parse_var()
         else:
             raise KconfigParserError(self, 'Expected "!" or "(" or identifier')
+        return val
 
     # disj: primary (OR primary)*
     def parse_disj(self):
-        self.parse_primary()
+        lhs = self.parse_primary()
         while self.tok == TOK_OR:
             self.get_token()
-            self.parse_primary()
+            lhs = lhs | self.parse_primary()
+        return lhs
 
     # expr: disj (AND disj)*
     def parse_expr(self):
-        self.parse_disj()
+        lhs = self.parse_disj()
         while self.tok == TOK_AND:
             self.get_token()
-            self.parse_disj()
+            lhs = lhs & self.parse_disj()
+        return lhs
 
     # condition: IF expr
     #       | empty
@@ -420,4 +498,6 @@ class KconfigParser:
 
 if __name__ == '__main__':
     fname = len(sys.argv) > 1 and sys.argv[1] or 'Kconfig.test'
-    KconfigParser.parse(open(fname, 'r'))
+    data = KconfigParser.parse(open(fname, 'r'))
+    for i in data.clauses:
+        print i
-- 
2.17.1

  parent reply	other threads:[~2019-01-23  6:59 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-23  6:55 [Qemu-devel] [RFC PATCH v4 00/44] Support Kconfig in QEMU Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 01/44] hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 02/44] build: actually use CONFIG_PAM Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 03/44] hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 04/44] hw/arm/Makefile.objs: CONFIG_VIRT created for virt board Yang Zhong
2019-01-23 21:06   ` Richard Henderson
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 05/44] hw/m68k/Makefile.objs: Conditionally build boards Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 06/44] hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards Yang Zhong
2019-01-23 15:20   ` Thomas Huth
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 07/44] hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards Yang Zhong
2019-01-23 15:36   ` Thomas Huth
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 08/44] hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_* Yang Zhong
2019-01-23 15:45   ` Thomas Huth
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 09/44] hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device Yang Zhong
2019-01-23 15:58   ` Thomas Huth
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 10/44] hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 11/44] hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 12/44] hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 13/44] hw/nios2/Makefile.objs: Conditionally build nios2 Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 14/44] hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards Yang Zhong
2019-01-23 16:11   ` Thomas Huth
2019-01-23 21:59     ` Alistair Francis
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 15/44] hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64 Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 16/44] hw/alpha/Makefile.objs: Create CONFIG_* for alpha Yang Zhong
2019-01-23 16:14   ` Thomas Huth
2019-01-23 21:11   ` Richard Henderson
2019-01-24  9:09     ` Thomas Huth
2019-01-24 10:52       ` Paolo Bonzini
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 17/44] hw/cris/Makefile.objs: Create CONFIG_* for cris Yang Zhong
2019-01-23 16:17   ` Thomas Huth
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 18/44] hw/hppa/Makefile.objs: Create CONFIG_* for hppa Yang Zhong
2019-01-23 16:23   ` Thomas Huth
2019-01-23 21:15   ` Richard Henderson
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 19/44] hw/moxie/Makefile.objs: Conditionally build moxie Yang Zhong
2019-01-23 16:26   ` Thomas Huth
2019-01-23 21:16   ` Richard Henderson
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 20/44] hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc Yang Zhong
2019-01-23 16:41   ` Thomas Huth
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 21/44] hw/tricore/Makefile.objs: Create CONFIG_* for tricore Yang Zhong
2019-01-23 16:43   ` Thomas Huth
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 22/44] minikconfig: add parser skeleton Yang Zhong
2019-01-23  6:55 ` Yang Zhong [this message]
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 24/44] minikconfig: add semantic analysis Yang Zhong
2019-01-23  6:55 ` [Qemu-devel] [RFC PATCH v4 25/44] hw/display: make edid configurable Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 26/44] kconfig: introduce kconfig files Yang Zhong
2019-01-24 14:06   ` Thomas Huth
2019-01-25  2:18     ` Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 27/44] build: switch to Kconfig Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 28/44] ide: express dependencies with Kconfig Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 29/44] hw/pci/Makefile.objs: make pcie configurable Yang Zhong
2019-01-23 14:23   ` Michael S. Tsirkin
2019-01-25  2:10     ` Yang Zhong
2019-01-25  2:43       ` Michael S. Tsirkin
2019-01-25  2:48         ` Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 30/44] build: convert pci.mak to Kconfig Yang Zhong
2019-01-23 21:19   ` Richard Henderson
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 31/44] build: convert sound.mak " Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 32/44] build: convert usb.mak " Yang Zhong
2019-01-23 21:19   ` Richard Henderson
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 33/44] scsi: express dependencies with Kconfig Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 34/44] bluetooth: " Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 35/44] isa: express dependencies with kconfig Yang Zhong
2019-01-24 12:23   ` Thomas Huth
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 36/44] i386: express dependencies with Kconfig Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 37/44] i2c: " Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 38/44] ptimer: " Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 39/44] edid: express dependencies with kconfig Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 40/44] hyperv: " Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 41/44] virtio: make virtio dependencies with Kconfig Yang Zhong
2019-01-24 12:51   ` Thomas Huth
2019-01-24 13:33     ` Yang Zhong
2019-01-24 14:10     ` Paolo Bonzini
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 42/44] i386-softmmu.mak: remove all CONFIG_* except boards definitions Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 43/44] minikconf: implement allyesconfig, allnoconfig, randconfig, defconfig Yang Zhong
2019-01-23  6:56 ` [Qemu-devel] [RFC PATCH v4 44/44] Makefile: only support defconfig Yang Zhong
2019-01-24  1:09 ` [Qemu-devel] [RFC PATCH v4 00/44] Support Kconfig in QEMU Paolo Bonzini
2019-01-24  2:00   ` Yang Zhong
2019-01-24  7:39     ` Paolo Bonzini
2019-01-24  2:38   ` BALATON Zoltan
2019-01-24  7:36     ` Paolo Bonzini
2019-01-31 22:15 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190123065618.3520-24-yang.zhong@intel.com \
    --to=yang.zhong@intel.com \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sameo@linux.intel.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).