From: Peter Xu <peterx@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, jemmy858585@gmail.com, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH] migration/rdma: unegister fd handler
Date: Wed, 23 Jan 2019 16:13:51 +0800 [thread overview]
Message-ID: <20190123081351.GB18231@xz-x1> (raw)
In-Reply-To: <20190122173111.29821-1-dgilbert@redhat.com>
On Tue, Jan 22, 2019 at 05:31:11PM +0000, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Unregister the fd handler before we destroy the channel,
> otherwise we've got a race where we might land in the
> fd handler just as we're closing the device.
>
> (The race is quite data dependent, you just have to have
> the right set of devices for it to trigger).
>
> Corresponds to RH bz: https://bugzilla.redhat.com/show_bug.cgi?id=1666601
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
(Could the crash happened because the same fd number is re-used after
the RDMA channel was destroyed? Then when the fd has an event, it'll
be delivered to rdma_cm_poll_handler() while the fd is not really the
RDMA channel handle any more)
Reviewed-by: Peter Xu <peterx@redhat.com>
Regards,
--
Peter Xu
next prev parent reply other threads:[~2019-01-23 8:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 17:31 [Qemu-devel] [PATCH] migration/rdma: unegister fd handler Dr. David Alan Gilbert (git)
2019-01-23 8:13 ` Peter Xu [this message]
2019-01-23 9:31 ` Dr. David Alan Gilbert
2019-01-23 11:44 ` Dr. David Alan Gilbert
2019-01-23 18:30 ` Philippe Mathieu-Daudé
2019-01-23 18:31 ` Dr. David Alan Gilbert
2019-02-14 18:08 ` Peter Maydell
2019-02-14 18:37 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123081351.GB18231@xz-x1 \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jemmy858585@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).