From: Gerd Hoffmann <kraxel@redhat.com>
To: Ryan El Kochta <relkochta@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] input-linux: customizable grab toggle keys v5
Date: Wed, 23 Jan 2019 09:15:29 +0100 [thread overview]
Message-ID: <20190123081529.nft2b673rrdivymp@sirius.home.kraxel.org> (raw)
In-Reply-To: <20190122205627.10182-1-relkochta@gmail.com>
On Tue, Jan 22, 2019 at 03:56:27PM -0500, Ryan El Kochta wrote:
> Here is an updated version of my previous patch. Ctrl-Alt has been
> removed, as per your recommendation, and Ctrl-Scrolllock has been
> changed so as to trigger when either ctrl key is pressed, for a
> consistent naming scheme. I do agree that this is the best way forward.
>
> Ctrl-Backtick is also gone.
>
> I've tested these on a Windows and Linux guest and they all appear to
> work fine.
Almost there. Code is fine now, but the commit message describes the v4
-> v5 changes instead of describing the patch. The v4 message was much
better.
Can you grab the v4 commit message and adapt the text to the v5 code
changes?
A better place to list the changes is the patch series cover letter
(yes, you can send a cover letter with a single patch too).
Some people use "git notes" + "git format-patch --notes" for changelog
annotations. That'll work too.
> Quick aside; I'm sorry if this e-mail isn't a reply to the old thread. I
> haven't quite figured that one out yet :-)
Starting a new thread is perfectly fine and in fact the preferred way to
send a new patch revision.
cheers,
Gerd
prev parent reply other threads:[~2019-01-23 8:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 20:56 [Qemu-devel] [PATCH] input-linux: customizable grab toggle keys v5 Ryan El Kochta
2019-01-23 8:15 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123081529.nft2b673rrdivymp@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=relkochta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).