From: Stefano Garzarella <sgarzare@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] block: Remove blk_attach_dev_legacy() / legacy_dev code
Date: Wed, 23 Jan 2019 10:48:37 +0100 [thread overview]
Message-ID: <20190123094837.cnhcyigojauwzakm@steredhat> (raw)
In-Reply-To: <1548233761-19890-1-git-send-email-thuth@redhat.com>
On Wed, Jan 23, 2019 at 09:56:01AM +0100, Thomas Huth wrote:
> The last user of blk_attach_dev_legacy() was the code in xen_disk which
> has recently been reworked. Now there is no user for this legacy function
> anymore. Thus we can finally remove all code related to the "legacy_dev"
> flag, too, and turn the related "void *" in block-backend.c into proper
> "DeviceState *" to fix some of the remaining TODOs there.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> v2: xen_disk.c is gone, no need to update it anymore
>
> block/block-backend.c | 54 +++++++-----------------------------------
> include/sysemu/block-backend.h | 5 ++--
> 2 files changed, 11 insertions(+), 48 deletions(-)
>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
next prev parent reply other threads:[~2019-01-23 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 8:56 [Qemu-devel] [PATCH v2] block: Remove blk_attach_dev_legacy() / legacy_dev code Thomas Huth
2019-01-23 9:48 ` Stefano Garzarella [this message]
2019-01-23 10:09 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123094837.cnhcyigojauwzakm@steredhat \
--to=sgarzare@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).