From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH] vmstate: constify SaveVMHandlers
Date: Wed, 23 Jan 2019 12:03:26 +0000 [thread overview]
Message-ID: <20190123120326.GD5771@work-vm> (raw)
In-Reply-To: <20181114133139.27346-1-marcandre.lureau@redhat.com>
* Marc-André Lureau (marcandre.lureau@redhat.com) wrote:
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Queued
> ---
> include/migration/register.h | 2 +-
> migration/savevm.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/migration/register.h b/include/migration/register.h
> index d287f4c317..3d0b9833c6 100644
> --- a/include/migration/register.h
> +++ b/include/migration/register.h
> @@ -72,7 +72,7 @@ int register_savevm_live(DeviceState *dev,
> const char *idstr,
> int instance_id,
> int version_id,
> - SaveVMHandlers *ops,
> + const SaveVMHandlers *ops,
> void *opaque);
>
> void unregister_savevm(DeviceState *dev, const char *idstr, void *opaque);
> diff --git a/migration/savevm.c b/migration/savevm.c
> index 236b242642..00a054721a 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -303,7 +303,7 @@ typedef struct SaveStateEntry {
> int section_id;
> /* section id read from the stream */
> int load_section_id;
> - SaveVMHandlers *ops;
> + const SaveVMHandlers *ops;
> const VMStateDescription *vmsd;
> void *opaque;
> CompatEntry *compat;
> @@ -614,7 +614,7 @@ int register_savevm_live(DeviceState *dev,
> const char *idstr,
> int instance_id,
> int version_id,
> - SaveVMHandlers *ops,
> + const SaveVMHandlers *ops,
> void *opaque)
> {
> SaveStateEntry *se;
> --
> 2.19.1.708.g4ede3d42df
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2019-01-23 12:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 13:31 [Qemu-devel] [PATCH] vmstate: constify SaveVMHandlers Marc-André Lureau
2018-11-30 20:08 ` Dr. David Alan Gilbert
2019-01-23 12:03 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123120326.GD5771@work-vm \
--to=dgilbert@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).