* [Qemu-devel] [PATCH] vmstate: constify SaveVMHandlers
@ 2018-11-14 13:31 Marc-André Lureau
2018-11-30 20:08 ` Dr. David Alan Gilbert
2019-01-23 12:03 ` Dr. David Alan Gilbert
0 siblings, 2 replies; 3+ messages in thread
From: Marc-André Lureau @ 2018-11-14 13:31 UTC (permalink / raw)
To: qemu-devel; +Cc: dgilbert, quintela, Marc-André Lureau
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
include/migration/register.h | 2 +-
migration/savevm.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/migration/register.h b/include/migration/register.h
index d287f4c317..3d0b9833c6 100644
--- a/include/migration/register.h
+++ b/include/migration/register.h
@@ -72,7 +72,7 @@ int register_savevm_live(DeviceState *dev,
const char *idstr,
int instance_id,
int version_id,
- SaveVMHandlers *ops,
+ const SaveVMHandlers *ops,
void *opaque);
void unregister_savevm(DeviceState *dev, const char *idstr, void *opaque);
diff --git a/migration/savevm.c b/migration/savevm.c
index 236b242642..00a054721a 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -303,7 +303,7 @@ typedef struct SaveStateEntry {
int section_id;
/* section id read from the stream */
int load_section_id;
- SaveVMHandlers *ops;
+ const SaveVMHandlers *ops;
const VMStateDescription *vmsd;
void *opaque;
CompatEntry *compat;
@@ -614,7 +614,7 @@ int register_savevm_live(DeviceState *dev,
const char *idstr,
int instance_id,
int version_id,
- SaveVMHandlers *ops,
+ const SaveVMHandlers *ops,
void *opaque)
{
SaveStateEntry *se;
--
2.19.1.708.g4ede3d42df
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] vmstate: constify SaveVMHandlers
2018-11-14 13:31 [Qemu-devel] [PATCH] vmstate: constify SaveVMHandlers Marc-André Lureau
@ 2018-11-30 20:08 ` Dr. David Alan Gilbert
2019-01-23 12:03 ` Dr. David Alan Gilbert
1 sibling, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2018-11-30 20:08 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: qemu-devel, quintela
* Marc-André Lureau (marcandre.lureau@redhat.com) wrote:
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> include/migration/register.h | 2 +-
> migration/savevm.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/migration/register.h b/include/migration/register.h
> index d287f4c317..3d0b9833c6 100644
> --- a/include/migration/register.h
> +++ b/include/migration/register.h
> @@ -72,7 +72,7 @@ int register_savevm_live(DeviceState *dev,
> const char *idstr,
> int instance_id,
> int version_id,
> - SaveVMHandlers *ops,
> + const SaveVMHandlers *ops,
> void *opaque);
>
> void unregister_savevm(DeviceState *dev, const char *idstr, void *opaque);
> diff --git a/migration/savevm.c b/migration/savevm.c
> index 236b242642..00a054721a 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -303,7 +303,7 @@ typedef struct SaveStateEntry {
> int section_id;
> /* section id read from the stream */
> int load_section_id;
> - SaveVMHandlers *ops;
> + const SaveVMHandlers *ops;
> const VMStateDescription *vmsd;
> void *opaque;
> CompatEntry *compat;
> @@ -614,7 +614,7 @@ int register_savevm_live(DeviceState *dev,
> const char *idstr,
> int instance_id,
> int version_id,
> - SaveVMHandlers *ops,
> + const SaveVMHandlers *ops,
> void *opaque)
> {
> SaveStateEntry *se;
> --
> 2.19.1.708.g4ede3d42df
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] vmstate: constify SaveVMHandlers
2018-11-14 13:31 [Qemu-devel] [PATCH] vmstate: constify SaveVMHandlers Marc-André Lureau
2018-11-30 20:08 ` Dr. David Alan Gilbert
@ 2019-01-23 12:03 ` Dr. David Alan Gilbert
1 sibling, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2019-01-23 12:03 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: qemu-devel, quintela
* Marc-André Lureau (marcandre.lureau@redhat.com) wrote:
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Queued
> ---
> include/migration/register.h | 2 +-
> migration/savevm.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/migration/register.h b/include/migration/register.h
> index d287f4c317..3d0b9833c6 100644
> --- a/include/migration/register.h
> +++ b/include/migration/register.h
> @@ -72,7 +72,7 @@ int register_savevm_live(DeviceState *dev,
> const char *idstr,
> int instance_id,
> int version_id,
> - SaveVMHandlers *ops,
> + const SaveVMHandlers *ops,
> void *opaque);
>
> void unregister_savevm(DeviceState *dev, const char *idstr, void *opaque);
> diff --git a/migration/savevm.c b/migration/savevm.c
> index 236b242642..00a054721a 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -303,7 +303,7 @@ typedef struct SaveStateEntry {
> int section_id;
> /* section id read from the stream */
> int load_section_id;
> - SaveVMHandlers *ops;
> + const SaveVMHandlers *ops;
> const VMStateDescription *vmsd;
> void *opaque;
> CompatEntry *compat;
> @@ -614,7 +614,7 @@ int register_savevm_live(DeviceState *dev,
> const char *idstr,
> int instance_id,
> int version_id,
> - SaveVMHandlers *ops,
> + const SaveVMHandlers *ops,
> void *opaque)
> {
> SaveStateEntry *se;
> --
> 2.19.1.708.g4ede3d42df
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-23 12:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-14 13:31 [Qemu-devel] [PATCH] vmstate: constify SaveVMHandlers Marc-André Lureau
2018-11-30 20:08 ` Dr. David Alan Gilbert
2019-01-23 12:03 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).