qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org
Cc: quintela@redhat.com, peterx@redhat.com,
	xiaoguangrong@tencent.com, marcandre.lureau@redhat.com,
	shirley17fei@gmail.com, lifei1214@126.com
Subject: [Qemu-devel] [PULL 6/9] migration/rdma: unregister fd handler
Date: Wed, 23 Jan 2019 15:58:27 +0000	[thread overview]
Message-ID: <20190123155830.8459-7-dgilbert@redhat.com> (raw)
In-Reply-To: <20190123155830.8459-1-dgilbert@redhat.com>

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Unregister the fd handler before we destroy the channel,
otherwise we've got a race where we might land in the
fd handler just as we're closing the device.

(The race is quite data dependent, you just have to have
the right set of devices for it to trigger).

Corresponds to RH bz: https://bugzilla.redhat.com/show_bug.cgi?id=1666601

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20190122173111.29821-1-dgilbert@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 migration/rdma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/migration/rdma.c b/migration/rdma.c
index 9b2e7e10aa..54a3c11540 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -2321,6 +2321,7 @@ static void qemu_rdma_cleanup(RDMAContext *rdma)
         rdma->connected = false;
     }
 
+    qemu_set_fd_handler(rdma->channel->fd, NULL, NULL, NULL);
     g_free(rdma->dest_blocks);
     rdma->dest_blocks = NULL;
 
-- 
2.20.1

  parent reply	other threads:[~2019-01-23 15:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-23 15:58 [Qemu-devel] [PULL 0/9] migration queue Dr. David Alan Gilbert (git)
2019-01-23 15:58 ` [Qemu-devel] [PULL 1/9] Fix segmentation fault when qemu_signal_init fails Dr. David Alan Gilbert (git)
2019-01-23 15:58 ` [Qemu-devel] [PULL 2/9] migration: fix the multifd code when receiving less channels Dr. David Alan Gilbert (git)
2019-01-23 15:58 ` [Qemu-devel] [PULL 3/9] migration: multifd_save_cleanup() can't fail, simplify Dr. David Alan Gilbert (git)
2019-01-23 15:58 ` [Qemu-devel] [PULL 4/9] migration: add more error handling for postcopy_ram_enable_notify Dr. David Alan Gilbert (git)
2019-01-23 15:58 ` [Qemu-devel] [PULL 5/9] migration: unify error handling for process_incoming_migration_co Dr. David Alan Gilbert (git)
2019-01-23 15:58 ` Dr. David Alan Gilbert (git) [this message]
2019-01-23 15:58 ` [Qemu-devel] [PULL 7/9] tests: add /vmstate/simple/array Dr. David Alan Gilbert (git)
2019-01-23 15:58 ` [Qemu-devel] [PULL 8/9] vmstate: constify SaveVMHandlers Dr. David Alan Gilbert (git)
2019-01-23 15:58 ` [Qemu-devel] [PULL 9/9] migration: introduce pages-per-second Dr. David Alan Gilbert (git)
2019-01-24 15:04 ` [Qemu-devel] [PULL 0/9] migration queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190123155830.8459-7-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=lifei1214@126.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=shirley17fei@gmail.com \
    --cc=xiaoguangrong@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).