qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org
Cc: quintela@redhat.com, peterx@redhat.com,
	xiaoguangrong@tencent.com, marcandre.lureau@redhat.com,
	shirley17fei@gmail.com, lifei1214@126.com
Subject: [Qemu-devel] [PULL 7/9] tests: add /vmstate/simple/array
Date: Wed, 23 Jan 2019 15:58:28 +0000	[thread overview]
Message-ID: <20190123155830.8459-8-dgilbert@redhat.com> (raw)
In-Reply-To: <20190123155830.8459-1-dgilbert@redhat.com>

From: Marc-André Lureau <marcandre.lureau@redhat.com>

A very simple test to show VMSTATE_*_ARRAY usage and result. It could
be systematically extended to other primitives, but I leave that as an
exercise for others :).

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20181114132130.27141-1-marcandre.lureau@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 tests/test-vmstate.c | 50 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
index 0ab29a8216..fc8ce62471 100644
--- a/tests/test-vmstate.c
+++ b/tests/test-vmstate.c
@@ -284,6 +284,55 @@ static void test_simple_primitive(void)
     FIELD_EQUAL(i64_2);
 }
 
+typedef struct TestSimpleArray {
+    uint16_t u16_1[3];
+} TestSimpleArray;
+
+/* Object instantiation, we are going to use it in more than one test */
+
+TestSimpleArray obj_simple_arr = {
+    .u16_1 = { 0x42, 0x43, 0x44 },
+};
+
+/* Description of the values.  If you add a primitive type
+   you are expected to add a test here */
+
+static const VMStateDescription vmstate_simple_arr = {
+    .name = "simple/array",
+    .version_id = 1,
+    .minimum_version_id = 1,
+    .fields = (VMStateField[]) {
+        VMSTATE_UINT16_ARRAY(u16_1, TestSimpleArray, 3),
+        VMSTATE_END_OF_LIST()
+    }
+};
+
+uint8_t wire_simple_arr[] = {
+    /* u16_1 */ 0x00, 0x42,
+    /* u16_1 */ 0x00, 0x43,
+    /* u16_1 */ 0x00, 0x44,
+    QEMU_VM_EOF, /* just to ensure we won't get EOF reported prematurely */
+};
+
+static void obj_simple_arr_copy(void *target, void *source)
+{
+    memcpy(target, source, sizeof(TestSimpleArray));
+}
+
+static void test_simple_array(void)
+{
+    TestSimpleArray obj, obj_clone;
+
+    memset(&obj, 0, sizeof(obj));
+    save_vmstate(&vmstate_simple_arr, &obj_simple_arr);
+
+    compare_vmstate(wire_simple_arr, sizeof(wire_simple_arr));
+
+    SUCCESS(load_vmstate(&vmstate_simple_arr, &obj, &obj_clone,
+                         obj_simple_arr_copy, 1, wire_simple_arr,
+                         sizeof(wire_simple_arr)));
+}
+
 typedef struct TestStruct {
     uint32_t a, b, c, e;
     uint64_t d, f;
@@ -863,6 +912,7 @@ int main(int argc, char **argv)
 
     g_test_init(&argc, &argv, NULL);
     g_test_add_func("/vmstate/simple/primitive", test_simple_primitive);
+    g_test_add_func("/vmstate/simple/array", test_simple_array);
     g_test_add_func("/vmstate/versioned/load/v1", test_load_v1);
     g_test_add_func("/vmstate/versioned/load/v2", test_load_v2);
     g_test_add_func("/vmstate/field_exists/load/noskip", test_load_noskip);
-- 
2.20.1

  parent reply	other threads:[~2019-01-23 15:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-23 15:58 [Qemu-devel] [PULL 0/9] migration queue Dr. David Alan Gilbert (git)
2019-01-23 15:58 ` [Qemu-devel] [PULL 1/9] Fix segmentation fault when qemu_signal_init fails Dr. David Alan Gilbert (git)
2019-01-23 15:58 ` [Qemu-devel] [PULL 2/9] migration: fix the multifd code when receiving less channels Dr. David Alan Gilbert (git)
2019-01-23 15:58 ` [Qemu-devel] [PULL 3/9] migration: multifd_save_cleanup() can't fail, simplify Dr. David Alan Gilbert (git)
2019-01-23 15:58 ` [Qemu-devel] [PULL 4/9] migration: add more error handling for postcopy_ram_enable_notify Dr. David Alan Gilbert (git)
2019-01-23 15:58 ` [Qemu-devel] [PULL 5/9] migration: unify error handling for process_incoming_migration_co Dr. David Alan Gilbert (git)
2019-01-23 15:58 ` [Qemu-devel] [PULL 6/9] migration/rdma: unregister fd handler Dr. David Alan Gilbert (git)
2019-01-23 15:58 ` Dr. David Alan Gilbert (git) [this message]
2019-01-23 15:58 ` [Qemu-devel] [PULL 8/9] vmstate: constify SaveVMHandlers Dr. David Alan Gilbert (git)
2019-01-23 15:58 ` [Qemu-devel] [PULL 9/9] migration: introduce pages-per-second Dr. David Alan Gilbert (git)
2019-01-24 15:04 ` [Qemu-devel] [PULL 0/9] migration queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190123155830.8459-8-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=lifei1214@126.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=shirley17fei@gmail.com \
    --cc=xiaoguangrong@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).