From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:55944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmLaQ-0008Kx-9R for qemu-devel@nongnu.org; Wed, 23 Jan 2019 11:41:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmLaO-0000OK-FF for qemu-devel@nongnu.org; Wed, 23 Jan 2019 11:41:09 -0500 Date: Wed, 23 Jan 2019 16:35:54 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20190123163553.GD2193@work-vm> References: <3da8da19-72dc-8f5e-f2e1-820999994cb2@redhat.com> <20190123110417.69e41c38@doriath> <20190123112420.0fe8fb0c@doriath> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190123112420.0fe8fb0c@doriath> Subject: Re: [Qemu-devel] Aborts in iotest 169 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Max Reitz , Qemu-block , "qemu-devel@nongnu.org" , Vladimir Sementsov-Ogievskiy * Luiz Capitulino (lcapitulino@redhat.com) wrote: > On Wed, 23 Jan 2019 17:12:35 +0100 > Max Reitz wrote: > > > On 23.01.19 17:04, Luiz Capitulino wrote: > > > On Wed, 23 Jan 2019 16:48:49 +0100 > > > Max Reitz wrote: > > > > > >> Hi, > > >> > > >> When running 169 in parallel (e.g. like so: > > >> > > >> $ while TEST_DIR=/tmp/t0 ./check -T -qcow2 169; do; done > > >> $ while TEST_DIR=/tmp/t1 ./check -T -qcow2 169; do; done > > >> $ while TEST_DIR=/tmp/t2 ./check -T -qcow2 169; do; done > > >> $ while TEST_DIR=/tmp/t3 ./check -T -qcow2 169; do; done > > >> > > >> in four different shells), I get aborts: > > > > > > OK, is this part of a test-suite that's also running migration > > > tests in parallel or in sequence? In other words, what does > > > iotests have to do with migration (sorry if this is stupid > > > question, but it's been years I don't do qemu). > > > > They run migration tests in sequence, but if you run multiple test > > instances in parallel, well, then they will be run in parallel. > > > > The only reason I CC'd you was because you were so prominent in git > > blame. O:-) > > Yeah, that's often the case with me :-) > > > > When this happened in the past it meant some QEMU code skipped a > > > transition, but I can't tell what this has to do with iotests. > > > > Well, this iotest (which tests a migration configuration) sometimes > > apparently results in this invalid transition. But that can't be just > > the test's fault, as qemu should handle that gracefully. > > Does iotest run a guest or does it only executes parts of qemu > code? If it's the latter, then I'd guess the test code is missing > calling qemu code that sets the appropriate state between > running and postmigrate states. > > > It's probably an issue in the migration code and not so much in vl.c, yes... > > Yeah, I'll let the migration people jump in. Can we get a log of the qmp commands when it fails? A 'running->postmigrate' transition is a bit weird; you could get a something->postmigrate if you migrate a VM twice, and the source is already in postmigrate, so it tells the destination to go into postmigrate. That's odd in itself, but not *that* odd. But then why is it going running->postmigrate? That suggests the source is currently running when it receives an incoming migration, and that really shouldn't happen. Dave -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK