From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:41926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmMKU-0002wW-OP for qemu-devel@nongnu.org; Wed, 23 Jan 2019 12:28:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmMKT-0002q9-MQ for qemu-devel@nongnu.org; Wed, 23 Jan 2019 12:28:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33114) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gmMKT-0002i9-Fi for qemu-devel@nongnu.org; Wed, 23 Jan 2019 12:28:45 -0500 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Date: Wed, 23 Jan 2019 17:27:31 +0000 Message-Id: <20190123172740.32452-8-berrange@redhat.com> In-Reply-To: <20190123172740.32452-1-berrange@redhat.com> References: <20190123172740.32452-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2 07/16] chardev: ensure qemu_chr_parse_compat reports missing driver error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Thomas Huth , Paolo Bonzini , Laurent Vivier , Yongji Xie , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= If no valid char driver was identified the qemu_chr_parse_compat method was silent, leaving callers no clue what failed. Signed-off-by: Daniel P. Berrang=C3=A9 --- chardev/char.c | 2 ++ tests/test-char.c | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/chardev/char.c b/chardev/char.c index ccba36bafb..b99f3692f7 100644 --- a/chardev/char.c +++ b/chardev/char.c @@ -490,6 +490,8 @@ QemuOpts *qemu_chr_parse_compat(const char *label, co= nst char *filename, return opts; } =20 + error_report("'%s' is not a valid char driver", filename); + fail: qemu_opts_del(opts); return NULL; diff --git a/tests/test-char.c b/tests/test-char.c index 19c3efad72..a93908f044 100644 --- a/tests/test-char.c +++ b/tests/test-char.c @@ -856,9 +856,10 @@ static void char_null_test(void) static void char_invalid_test(void) { Chardev *chr; - + setenv("QTEST_SILENT_ERRORS", "1", 1); chr =3D qemu_chr_new("label-invalid", "invalid"); g_assert_null(chr); + unsetenv("QTEST_SILENT_ERRORS"); } =20 static int chardev_change(void *opaque) --=20 2.20.1