From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:58693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmNH5-0005DA-LC for qemu-devel@nongnu.org; Wed, 23 Jan 2019 13:29:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmNH3-0005xf-TA for qemu-devel@nongnu.org; Wed, 23 Jan 2019 13:29:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60174) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gmNH3-0005um-Mg for qemu-devel@nongnu.org; Wed, 23 Jan 2019 13:29:17 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E6EBCC7C13 for ; Wed, 23 Jan 2019 18:29:14 +0000 (UTC) Date: Wed, 23 Jan 2019 18:28:59 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20190123182858.GG2193@work-vm> References: <20190122200740.GC2241@work-vm> <20190122215941-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190122215941-mutt-send-email-mst@kernel.org> Subject: Re: [Qemu-devel] of apci_1_compatible in CPUHotplugFeatures List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: imammedo@redhat.com, qemu-devel@nongnu.org * Michael S. Tsirkin (mst@redhat.com) wrote: > On Tue, Jan 22, 2019 at 08:07:41PM +0000, Dr. David Alan Gilbert wrote: > > Hi, > > I noticed that the acpi_1_compatible flag was misspelt as > > apci_1_compatible > > > > so have a trivial patch to fix that, but looking at it - are > > thre any cases where a[cp]i_1_compatible can possibly be false? > > > > Dave > > legacy_cpu_hotplug so machine 2.6 and older - no? That doesn't seem to affect that flag by my reading; the only place I see legacy_cpu_hotplug checked is acpi-build.c:build_dsdt and we have: if (pcmc->legacy_cpu_hotplug) { build_legacy_cpu_hotplug_aml(dsdt, machine, pm->cpu_hp_io_base); } else { CPUHotplugFeatures opts = { .acpi_1_compatible = true, .has_legacy_cphp = true }; build_cpus_aml(dsdt, machine, opts, pm->cpu_hp_io_base, "\\_SB.PCI0", "\\_GPE._E02"); } so the 'opts' field is only used in the non-legacy case. That's the only caller of build_cpus_aml, and I'm not seeing another user of CPUHotplugFeatures. Dave > > -- > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK