From: Aaron Lindsay OS <aaron@os.amperecomputing.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
Alistair Francis <alistair.francis@xilinx.com>,
Wei Huang <wei@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Richard Henderson <richard.henderson@linaro.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Michael Spradling <mspradli@codeaurora.org>,
Digant Desai <digantd@codeaurora.org>
Subject: Re: [Qemu-devel] [PATCH v10 00/14] More fully implement ARM PMUv3
Date: Wed, 23 Jan 2019 20:04:57 +0000 [thread overview]
Message-ID: <20190123200459.GE5213@quinoa.localdomain> (raw)
In-Reply-To: <CAFEAcA8Kvx9ATDgj5mOqcJGQf_T-Sw0ut5N6w3CBs9pBA4d1_A@mail.gmail.com>
On Jan 18 14:13, Peter Maydell wrote:
> On Tue, 11 Dec 2018 at 15:20, Aaron Lindsay
> <aaron@os.amperecomputing.com> wrote:
> >
> > The ARM PMU implementation currently contains a basic cycle counter, but
> > it is often useful to gather counts of other events, filter them based
> > on execution mode, and/or be notified on counter overflow. These patches
> > flesh out the implementations of various PMU registers including
> > PM[X]EVCNTR and PM[X]EVTYPER, add a struct definition to represent
> > arbitrary counter types, implement mode filtering, send interrupts on
> > counter overflow, and add instruction, cycle, and software increment
> > events.
> >
> > Since v9 [1] I have made the following changes:
> > * Added a clarifying comment about how the PMU timer's migration is
> > handled
> > * Added a check against implementing PMCEID[23] if ID_DFR0.PerfMon ==
> > 0xf
> > * Added TRACEFILT to the ID_DFR0 field definitions
> >
> > [1] - https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg00805.html
> >
>
> Richard has made some comments on patch 14; since 1-13 have
> all been reviewed now I'm going to apply those to target-arm.next.
Thanks.
I also apologize - I just uncovered a bug I should've caught sooner, and
sent out a fix to the list as:
Subject: [PATCH] target/arm: Don't clear supported PMU events when
initializing PMCEID1
-Aaron
prev parent reply other threads:[~2019-01-23 20:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 15:20 [Qemu-devel] [PATCH v10 00/14] More fully implement ARM PMUv3 Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 01/14] migration: Add post_save function to VMStateDescription Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 02/14] target/arm: Reorganize PMCCNTR accesses Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 03/14] target/arm: Swap PMU values before/after migrations Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 04/14] target/arm: Filter cycle counter based on PMCCFILTR_EL0 Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 05/14] target/arm: Allow AArch32 access for PMCCFILTR Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 06/14] target/arm: Implement PMOVSSET Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 07/14] target/arm: Define FIELDs for ID_DFR0 Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 08/14] target/arm: Make PMCEID[01]_EL0 64 bit registers, add PMCEID[23] Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 09/14] target/arm: Add array for supported PMU events, generate PMCEID[01]_EL0 Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 10/14] target/arm: Finish implementation of PM[X]EVCNTR and PM[X]EVTYPER Aaron Lindsay
2019-02-04 19:22 ` [Qemu-devel] [Qemu-arm] " Laurent Desnogues
2019-02-05 13:41 ` Aaron Lindsay OS
2019-02-05 13:54 ` Laurent Desnogues
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 11/14] target/arm: PMU: Add instruction and cycle events Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 12/14] target/arm: PMU: Set PMCR.N to 4 Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 13/14] target/arm: Implement PMSWINC Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 14/14] target/arm: Send interrupts on PMU counter overflow Aaron Lindsay
2019-01-17 20:26 ` Richard Henderson
2019-01-18 21:40 ` Aaron Lindsay
2019-01-18 21:58 ` Richard Henderson
2019-01-11 16:22 ` [Qemu-devel] [PATCH v10 00/14] More fully implement ARM PMUv3 Aaron Lindsay
2019-01-18 14:13 ` Peter Maydell
2019-01-23 20:04 ` Aaron Lindsay OS [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123200459.GE5213@quinoa.localdomain \
--to=aaron@os.amperecomputing.com \
--cc=alistair.francis@xilinx.com \
--cc=crosthwaite.peter@gmail.com \
--cc=digantd@codeaurora.org \
--cc=mspradli@codeaurora.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=wei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).