From: Gerd Hoffmann <kraxel@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-devel@nongnu.org, "Brad Smith" <brad@comstyle.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Michael Walle" <michael@walle.cc>, "Fam Zheng" <fam@euphon.net>,
"Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source
Date: Thu, 24 Jan 2019 12:43:05 +0100 [thread overview]
Message-ID: <20190124114305.bdxz76bsxk5lvc3d@sirius.home.kraxel.org> (raw)
In-Reply-To: <20190124011554.25418-5-philmd@redhat.com>
On Thu, Jan 24, 2019 at 02:15:54AM +0100, Philippe Mathieu-Daudé wrote:
> Move the complexity of milkymist_tmu2_create() into the
> source file. Doing so we avoid to include the X11/OpenGL
> headers in all LM32 devices, and we also avoid the duplicate
> declaration of glx_fbconfig_attr[] (it is already declared
> in hw/display/milkymist-tmu2.c).
> Since TYPE_MILKYMIST_TMU2 is now accessible, use it.
Oops, fails the build:
LINK lm32-softmmu/qemu-system-lm32
hw/lm32/milkymist.o: In function `milkymist_init':
milkymist.c:(.text+0xb0f): undefined reference to `milkymist_tmu2_create'
cheers,
Gerd
next prev parent reply other threads:[~2019-01-24 11:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 1:15 [Qemu-devel] [PATCH v2 0/4] sdl: Let it be optional (in particular, on OpenBSD) Philippe Mathieu-Daudé
2019-01-24 1:15 ` [Qemu-devel] [PATCH v2 1/4] configure: LM32 Milkymist Texture Mapping Unit (tmu2) also depends of X11 Philippe Mathieu-Daudé
2019-01-24 1:15 ` [Qemu-devel] [PATCH v2 2/4] hw/display/milkymist-tmu2: Explicit the dependency to both X11 / OpenGL Philippe Mathieu-Daudé
2019-01-24 1:15 ` [Qemu-devel] [PATCH v2 3/4] configure: Let SDL support be optional on OpenBSD Philippe Mathieu-Daudé
2019-01-24 11:23 ` Gerd Hoffmann
2019-01-24 13:51 ` Philippe Mathieu-Daudé
2019-01-24 15:33 ` Gerd Hoffmann
2019-01-24 11:44 ` Peter Maydell
2019-01-24 13:38 ` Philippe Mathieu-Daudé
2019-01-24 1:15 ` [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source Philippe Mathieu-Daudé
2019-01-24 11:43 ` Gerd Hoffmann [this message]
2019-01-24 13:37 ` Philippe Mathieu-Daudé
2019-01-28 17:47 ` Philippe Mathieu-Daudé
2019-01-28 18:02 ` Peter Maydell
2019-01-28 18:28 ` Philippe Mathieu-Daudé
2019-01-29 8:21 ` Paolo Bonzini
2019-01-29 10:17 ` Peter Maydell
2019-01-29 5:47 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190124114305.bdxz76bsxk5lvc3d@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=berrange@redhat.com \
--cc=brad@comstyle.com \
--cc=fam@euphon.net \
--cc=michael@walle.cc \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).