From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:44343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmeSK-00019M-0W for qemu-devel@nongnu.org; Thu, 24 Jan 2019 07:50:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmeSI-00015f-MP for qemu-devel@nongnu.org; Thu, 24 Jan 2019 07:50:03 -0500 From: Laurent Vivier Date: Thu, 24 Jan 2019 13:49:04 +0100 Message-Id: <20190124124906.16653-4-laurent@vivier.eu> In-Reply-To: <20190124124906.16653-1-laurent@vivier.eu> References: <20190124124906.16653-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PULL 3/5] ppc: e6500 registers SPR 604 twice List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Laurent Vivier , Paolo Bonzini , Eduardo Habkost , qemu-trivial@nongnu.org, "Michael S. Tsirkin" , David Gibson , Marcel Apfelbaum , qemu-ppc@nongnu.org, Richard Henderson , Michael Tokarev , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Jon Diekema From: Jon Diekema When using the e6500 CPU, QEMU generates a fatal error after complaining about registering SPR 604 twice. Building and testing with commit 9b2e891ec5ccdb4a7d583b77988848282606fdea shows the issue: qemu-system-ppc64 --version QEMU emulator version 3.1.50 (v3.1.0-456-g9b2e891ec5-dirty) Copyright (c) 2003-2018 Fabrice Bellard and the QEMU Project developers qemu-system-ppc64 -M none -cpu e6500 Error: Trying to register SPR 604 (25c) twice ! Signed-off-by: Jon Diekema Message-Id: [removed duplicated mail header in the commit message] Signed-off-by: Laurent Vivier --- target/ppc/translate_init.inc.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/target/ppc/translate_init.inc.c b/target/ppc/translate_init.inc.c index ade06cc773..59e0b86762 100644 --- a/target/ppc/translate_init.inc.c +++ b/target/ppc/translate_init.inc.c @@ -4947,14 +4947,6 @@ static void init_proc_e500(CPUPPCState *env, int version) } if (version == fsl_e6500) { - spr_register(env, SPR_BOOKE_SPRG8, "SPRG8", - SPR_NOACCESS, SPR_NOACCESS, - &spr_read_generic, &spr_write_generic, - 0x00000000); - spr_register(env, SPR_BOOKE_SPRG9, "SPRG9", - SPR_NOACCESS, SPR_NOACCESS, - &spr_read_generic, &spr_write_generic, - 0x00000000); /* Thread identification */ spr_register(env, SPR_TIR, "TIR", SPR_NOACCESS, SPR_NOACCESS, -- 2.20.1