* [Qemu-devel] [PATCH] hw: sd: set category of the sd memory card
@ 2019-01-24 16:20 kumar sourav
2019-01-24 17:17 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: kumar sourav @ 2019-01-24 16:20 UTC (permalink / raw)
To: qemu-trivial; +Cc: f4bug, qemu-devel, thuth
Sets the category of the sd memory card as DEVICE_CATEGORY_STORAGE.
Devices should be assigned to one of DEVICE_CATEGORY_XXXX.
Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
---
hw/sd/sd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index d4356e9b73..aaab15f386 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -2121,6 +2121,7 @@ static void sd_class_init(ObjectClass *klass, void *data)
dc->vmsd = &sd_vmstate;
dc->reset = sd_reset;
dc->bus_type = TYPE_SD_BUS;
+ set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
sc->set_voltage = sd_set_voltage;
sc->get_dat_lines = sd_get_dat_lines;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] hw: sd: set category of the sd memory card
2019-01-24 16:20 [Qemu-devel] [PATCH] hw: sd: set category of the sd memory card kumar sourav
@ 2019-01-24 17:17 ` Philippe Mathieu-Daudé
2019-01-28 9:08 ` Thomas Huth
2019-01-30 9:27 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-01-24 17:17 UTC (permalink / raw)
To: kumar sourav, qemu-trivial; +Cc: thuth, f4bug, qemu-devel
On 1/24/19 5:20 PM, kumar sourav wrote:
> Sets the category of the sd memory card as DEVICE_CATEGORY_STORAGE.
> Devices should be assigned to one of DEVICE_CATEGORY_XXXX.
>
> Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/sd/sd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index d4356e9b73..aaab15f386 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -2121,6 +2121,7 @@ static void sd_class_init(ObjectClass *klass, void *data)
> dc->vmsd = &sd_vmstate;
> dc->reset = sd_reset;
> dc->bus_type = TYPE_SD_BUS;
> + set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
>
> sc->set_voltage = sd_set_voltage;
> sc->get_dat_lines = sd_get_dat_lines;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] hw: sd: set category of the sd memory card
2019-01-24 16:20 [Qemu-devel] [PATCH] hw: sd: set category of the sd memory card kumar sourav
2019-01-24 17:17 ` Philippe Mathieu-Daudé
@ 2019-01-28 9:08 ` Thomas Huth
2019-01-30 9:27 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2019-01-28 9:08 UTC (permalink / raw)
To: kumar sourav, qemu-trivial; +Cc: f4bug, qemu-devel
On 2019-01-24 17:20, kumar sourav wrote:
> Sets the category of the sd memory card as DEVICE_CATEGORY_STORAGE.
> Devices should be assigned to one of DEVICE_CATEGORY_XXXX.
>
> Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
> ---
> hw/sd/sd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index d4356e9b73..aaab15f386 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -2121,6 +2121,7 @@ static void sd_class_init(ObjectClass *klass, void *data)
> dc->vmsd = &sd_vmstate;
> dc->reset = sd_reset;
> dc->bus_type = TYPE_SD_BUS;
> + set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
>
> sc->set_voltage = sd_set_voltage;
> sc->get_dat_lines = sd_get_dat_lines;
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw: sd: set category of the sd memory card
2019-01-24 16:20 [Qemu-devel] [PATCH] hw: sd: set category of the sd memory card kumar sourav
2019-01-24 17:17 ` Philippe Mathieu-Daudé
2019-01-28 9:08 ` Thomas Huth
@ 2019-01-30 9:27 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2019-01-30 9:27 UTC (permalink / raw)
To: kumar sourav, qemu-trivial; +Cc: thuth, f4bug, qemu-devel
On 24/01/2019 17:20, kumar sourav wrote:
> Sets the category of the sd memory card as DEVICE_CATEGORY_STORAGE.
> Devices should be assigned to one of DEVICE_CATEGORY_XXXX.
>
> Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
> ---
> hw/sd/sd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index d4356e9b73..aaab15f386 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -2121,6 +2121,7 @@ static void sd_class_init(ObjectClass *klass, void *data)
> dc->vmsd = &sd_vmstate;
> dc->reset = sd_reset;
> dc->bus_type = TYPE_SD_BUS;
> + set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
>
> sc->set_voltage = sd_set_voltage;
> sc->get_dat_lines = sd_get_dat_lines;
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-30 9:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-24 16:20 [Qemu-devel] [PATCH] hw: sd: set category of the sd memory card kumar sourav
2019-01-24 17:17 ` Philippe Mathieu-Daudé
2019-01-28 9:08 ` Thomas Huth
2019-01-30 9:27 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).