From: "Michael S. Tsirkin" <mst@redhat.com>
To: kumar sourav <sourav.jb1988@gmail.com>
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com,
qemu-devel@nongnu.org, thuth@redhat.com
Subject: Re: [Qemu-devel] [PATCH] hw: input: set category of the i8042 device
Date: Fri, 25 Jan 2019 14:46:24 -0500 [thread overview]
Message-ID: <20190125144613-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20190125151440.13794-1-sourav.jb1988@gmail.com>
On Fri, Jan 25, 2019 at 08:44:40PM +0530, kumar sourav wrote:
> Sets the category of i8042 device as DEVICE_CATEGORY_INPUT
> Devices should be assigned to one of DEVICE_CATEGORY_XXXX.
>
> Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
who's merging this? Paolo?
> ---
> hw/input/pckbd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c
> index 3e66713b47..72e7d5f6cc 100644
> --- a/hw/input/pckbd.c
> +++ b/hw/input/pckbd.c
> @@ -574,6 +574,7 @@ static void i8042_class_initfn(ObjectClass *klass, void *data)
>
> dc->realize = i8042_realizefn;
> dc->vmsd = &vmstate_kbd_isa;
> + set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
> }
>
> static const TypeInfo i8042_info = {
> --
> 2.17.1
next prev parent reply other threads:[~2019-01-25 19:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 15:14 [Qemu-devel] [PATCH] hw: input: set category of the i8042 device kumar sourav
2019-01-25 15:24 ` Thomas Huth
2019-01-25 16:44 ` Philippe Mathieu-Daudé
2019-01-25 18:00 ` ksourav
2019-01-25 19:47 ` Michael S. Tsirkin
2019-01-28 8:14 ` Thomas Huth
2019-01-25 19:46 ` Michael S. Tsirkin [this message]
2019-01-30 9:19 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125144613-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sourav.jb1988@gmail.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).