From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: xiaoguangrong.eric@gmail.com, stefanha@redhat.com,
pbonzini@redhat.com, pagupta@redhat.com,
yu.c.zhang@linux.intel.com, richardw.yang@linux.intel.com,
qemu-devel@nongnu.org, imammedo@redhat.com,
dan.j.williams@intel.com
Subject: Re: [Qemu-devel] [PATCH V10 4/4] docs: Added MAP_SYNC documentation
Date: Fri, 25 Jan 2019 15:03:35 -0500 [thread overview]
Message-ID: <20190125150133-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20190125032653.GC4136@habkost.net>
On Fri, Jan 25, 2019 at 01:26:53AM -0200, Eduardo Habkost wrote:
> > I think we need not be purists here. Most people don't lose power and
> > then it's fine and compatible. People who want more robustness need to
> > use more modern kernels, that is all.
>
> I don't think that's being purist.
Right I thought that you want to prevent kernel running this
on old kernels. Why it's nice to stay up to date this
flag was not backported into stable kernels so many users
can't really update.
> I want to avoid hidden bugs
Makes total sense, I posted a proposal.
> if we ignore that MAP_SYNC failed for any unexpected reason. If
> we need to ignore errors in some cases, let's at least limit that
> to cases where we absolutely have to.
>
> But I would also be happy with just a warning.
>
> --
> Eduardo
next prev parent reply other threads:[~2019-01-25 20:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 2:59 [Qemu-devel] [PATCH V10 0/4] support MAP_SYNC for memory-backend-file Zhang, Yi
2019-01-23 2:59 ` [Qemu-devel] [PATCH V10 1/4] util/mmap-alloc: switch 'shared' to 'flags' parameter Zhang, Yi
2019-01-23 15:01 ` Michael S. Tsirkin
2019-01-23 2:59 ` [Qemu-devel] [PATCH V10 2/4] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap() Zhang, Yi
2019-01-23 15:04 ` Michael S. Tsirkin
2019-01-24 14:15 ` Yi Zhang
2019-01-24 13:39 ` Michael S. Tsirkin
2019-01-23 2:59 ` [Qemu-devel] [PATCH V10 3/4] hostmem: add more information in error messages Zhang, Yi
2019-01-23 3:00 ` [Qemu-devel] [PATCH V10 4/4] docs: Added MAP_SYNC documentation Zhang, Yi
2019-01-23 14:50 ` Eduardo Habkost
2019-01-24 11:21 ` Yi Zhang
2019-01-24 16:59 ` Eduardo Habkost
2019-01-24 17:45 ` Michael S. Tsirkin
2019-01-24 18:28 ` Eduardo Habkost
2019-01-24 19:05 ` Michael S. Tsirkin
2019-01-24 19:14 ` Eduardo Habkost
2019-01-25 3:08 ` Michael S. Tsirkin
2019-01-25 3:26 ` Eduardo Habkost
2019-01-25 20:01 ` Michael S. Tsirkin
2019-01-25 20:03 ` Michael S. Tsirkin [this message]
2019-01-25 11:19 ` Yi Zhang
2019-01-23 3:01 ` [Qemu-devel] [PATCH V10 0/4] support MAP_SYNC for memory-backend-file Michael S. Tsirkin
2019-01-23 3:10 ` Yi Zhang
2019-01-23 3:53 ` Michael S. Tsirkin
2019-01-23 15:45 ` Yi Zhang
2019-01-23 4:02 ` Michael S. Tsirkin
2019-01-23 15:57 ` Yi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125150133-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richardw.yang@linux.intel.com \
--cc=stefanha@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
--cc=yu.c.zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).