From: Samuel Thibault <samuel.thibault@gnu.org>
To: Peter Maydell <peter.maydell@linaro.org>, Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, patches@linaro.org,
"Jan Kiszka" <jan.kiszka@siemens.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] slirp: fix -Waddress-of-packed-member warnings
Date: Sat, 26 Jan 2019 22:09:12 +0100 [thread overview]
Message-ID: <20190126210912.ktxrjcaw2cmexub4@function> (raw)
In-Reply-To: <6415e48b-ae20-2be7-590e-bd79142620b8@redhat.com> <20190122181822.1505-1-peter.maydell@linaro.org>
Hello,
Peter Maydell, le mar. 22 janv. 2019 18:18:20 +0000, a ecrit:
> These patches fix the clang -Waddress-of-packed-member warnings
> in the slirp code.
Applied to my tree, thanks!
Eric Blake, le mar. 22 janv. 2019 13:27:32 -0600, a ecrit:
> How does this series play with the ongoing effort to make libslirp an
> independent project? I'm assuming your use of QEMU_BUILD_BUG_ON() will
> have to be translated into whatever libslirp-specific mechanism we want
> to split off into that project.
Indeed, but I guess libslirp will want to have such kind of macro
anyway, so I don't see a reason to hold this change.
Samuel
prev parent reply other threads:[~2019-01-26 21:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 18:18 [Qemu-devel] [PATCH 0/2] slirp: fix -Waddress-of-packed-member warnings Peter Maydell
2019-01-22 18:18 ` [Qemu-devel] [PATCH 1/2] slirp: Avoid marking naturally packed structs as QEMU_PACKED Peter Maydell
2019-01-22 19:25 ` Eric Blake
2019-01-22 18:18 ` [Qemu-devel] [PATCH 2/2] slirp: Don't mark struct ipq or struct ipasfrag as packed Peter Maydell
2019-01-22 18:55 ` Daniel P. Berrangé
2019-01-22 18:57 ` Peter Maydell
2019-01-22 19:26 ` Eric Blake
2019-01-22 19:27 ` [Qemu-devel] [PATCH 0/2] slirp: fix -Waddress-of-packed-member warnings Eric Blake
2019-01-26 21:09 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190126210912.ktxrjcaw2cmexub4@function \
--to=samuel.thibault@gnu.org \
--cc=eblake@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=marcandre.lureau@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).