Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/input/adb.c: set device category of adb

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1647 bytes --]

On Mon, Jan 28, 2019 at 10:06:03AM +0100, Thomas Huth wrote:
> On 2019-01-27 11:02, kumar sourav wrote:
> > Sets the category of adb as DEVICE_CATEGORY_INPUT
> > Devices should be assigned to one of DEVICE_CATEGORY_XXXX
> > 
> > Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
> > ---
> >  hw/input/adb.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/hw/input/adb.c b/hw/input/adb.c
> > index bbb40aeef1..6ca7c5641c 100644
> > --- a/hw/input/adb.c
> > +++ b/hw/input/adb.c
> > @@ -126,6 +126,7 @@ static void adb_device_class_init(ObjectClass *oc, void *data)
> >      dc->realize = adb_device_realizefn;
> >      dc->props = adb_device_properties;
> >      dc->bus_type = TYPE_ADB_BUS;
> > +    set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
> >  }
> 
> This patch does not make too much sense in its current shape:
> TYPE_ADB_DEVICE is an abstract device and does not show up in the output
> of "-device help", so it is not necessary for this device itself.
> 
> Looking at the "child" devices adb-kdb and adb-mouse, they bother
> already set DEVICE_CATEGORY_INPUT in their own, so they are already fine.
> 
> Thus please do one of the following:
> 
> 1) Simply drop this patch.
> 
> 2) Keep setting the category here in the abstract parent class, but then
> also remove the DEVICE_CATEGORY_INPUT in the adb-kdb and adb-mouse child
> classes.

Ah, good point.  Dropped from ppc-for-4.0.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]