From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:53402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1go8di-0005Rj-D1 for qemu-devel@nongnu.org; Mon, 28 Jan 2019 10:15:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1go8dh-0004HM-H6 for qemu-devel@nongnu.org; Mon, 28 Jan 2019 10:15:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49612) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1go8dh-0004HF-BW for qemu-devel@nongnu.org; Mon, 28 Jan 2019 10:15:57 -0500 Date: Mon, 28 Jan 2019 10:15:55 -0500 From: "Michael S. Tsirkin" Message-ID: <20190128101331-mutt-send-email-mst@kernel.org> References: <20190125210058.1092551-1-stefanb@linux.ibm.com> <20190128154553.583f79a3@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190128154553.583f79a3@redhat.com> Subject: Re: [Qemu-devel] [PATCH] acpi: Make TPM 2.0 with TIS available as MSFT0101 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: Stefan Berger , qemu-devel@nongnu.org, marcandre.lureau@redhat.com On Mon, Jan 28, 2019 at 03:45:53PM +0100, Igor Mammedov wrote: > On Fri, 25 Jan 2019 16:00:58 -0500 > Stefan Berger wrote: > > > This patch makes the a TPM 2.0 with TIS interface available under the > > HID 'MSF0101'. This is supported by Linux and also Windows now > MSF0101 is relatively recent addition to Linux, > are there in wild (old) kernels that worked with PNP0C31 but won't work > with MSF0101? Well what would you do? You either have TPM 2.0 or you don't. If you have a 2.0 backend you need to expose it as 2.0 to the frontend right? > > recognizes the TPM 2.0 with TIS interface. Leave the TPM 1.2 as before. > > > > Signed-off-by: Stefan Berger > > --- > > hw/i386/acpi-build.c | 12 ++++++++++-- > > 1 file changed, 10 insertions(+), 2 deletions(-) > > > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > > index 2e21a31f82..f51225b4a7 100644 > > --- a/hw/i386/acpi-build.c > > +++ b/hw/i386/acpi-build.c > > @@ -2141,8 +2141,16 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, > > build_append_pci_bus_devices(scope, bus, pm->pcihp_bridge_en); > > > > if (TPM_IS_TIS(tpm)) { > > - dev = aml_device("ISA.TPM"); > > - aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0C31"))); > > + if (misc->tpm_version == TPM_VERSION_2_0) { > > + dev = aml_device("TPM"); > > + aml_append(dev, aml_name_decl("_HID", > > + aml_string("MSFT0101"))); > > + } else { > > + dev = aml_device("ISA.TPM"); > > + aml_append(dev, aml_name_decl("_HID", > > + aml_eisaid("PNP0C31"))); > > + } > > + > > aml_append(dev, aml_name_decl("_STA", aml_int(0xF))); > > crs = aml_resource_template(); > > aml_append(crs, aml_memory32_fixed(TPM_TIS_ADDR_BASE,