From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:50460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1go4MJ-00014V-Nt for qemu-devel@nongnu.org; Mon, 28 Jan 2019 05:41:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1go4MH-0007E3-MD for qemu-devel@nongnu.org; Mon, 28 Jan 2019 05:41:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57328) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1go4MG-0007AB-ND for qemu-devel@nongnu.org; Mon, 28 Jan 2019 05:41:41 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F17BB74EEC for ; Mon, 28 Jan 2019 10:41:33 +0000 (UTC) Date: Mon, 28 Jan 2019 11:41:29 +0100 From: Igor Mammedov Message-ID: <20190128114129.6c5ed63f@redhat.com> In-Reply-To: <20190125144831-mutt-send-email-mst@kernel.org> References: <20190122200740.GC2241@work-vm> <20190122215941-mutt-send-email-mst@kernel.org> <20190123182858.GG2193@work-vm> <20190125092605.2d40dce8@redhat.com> <20190125144831-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] of apci_1_compatible in CPUHotplugFeatures List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org On Fri, 25 Jan 2019 14:49:28 -0500 "Michael S. Tsirkin" wrote: > On Fri, Jan 25, 2019 at 09:26:05AM +0100, Igor Mammedov wrote: > > On Wed, 23 Jan 2019 18:28:59 +0000 > > "Dr. David Alan Gilbert" wrote: > > > > > * Michael S. Tsirkin (mst@redhat.com) wrote: > > > > On Tue, Jan 22, 2019 at 08:07:41PM +0000, Dr. David Alan Gilbert wrote: > > > > > Hi, > > > > > I noticed that the acpi_1_compatible flag was misspelt as > > > > > apci_1_compatible > > > > > > > > > > so have a trivial patch to fix that, > > pls post it. > > > > > > > but looking at it - are > > > > > thre any cases where a[cp]i_1_compatible can possibly be false? > > ATM it's not possible, but I've wrote it with intent to reuse > > build_cpus_aml() in arm/virt board and there we shall use newer > > aml_device() instead of legacy aml_processor(), hence a feature flag > > to toggle behavior. > > Are there imminent plans to do this? If not why don't we > drop unused code? One can always bring it back from git > history if need arises but for now there's no guarantee > it's not broken as it never runs. I'm working on it (I mean adding CPU hotplug support for ARM (QEMU side of it)), so I'd keep it. > > > > > > > > > > > > Dave > > > > > > > > legacy_cpu_hotplug so machine 2.6 and older - no? > > > > > > That doesn't seem to affect that flag by my reading; > > > the only place I see legacy_cpu_hotplug checked is > > > acpi-build.c:build_dsdt and we have: > > > > > > if (pcmc->legacy_cpu_hotplug) { > > > build_legacy_cpu_hotplug_aml(dsdt, machine, pm->cpu_hp_io_base); > > > } else { > > > CPUHotplugFeatures opts = { > > > .acpi_1_compatible = true, .has_legacy_cphp = true > > > }; > > > build_cpus_aml(dsdt, machine, opts, pm->cpu_hp_io_base, > > > "\\_SB.PCI0", "\\_GPE._E02"); > > > } > > > > > > so the 'opts' field is only used in the non-legacy case. > > > > > > That's the only caller of build_cpus_aml, and I'm not seeing another > > > user of CPUHotplugFeatures. > > > > > > Dave > > > > > > > > -- > > > > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK > > > -- > > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK