From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
Collin Walling <walling@linux.ibm.com>,
Thomas Huth <thuth@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v3 1/2] s390x/pci: Introduce unplug requests and split unplug handler
Date: Mon, 28 Jan 2019 12:27:16 +0100 [thread overview]
Message-ID: <20190128122716.35f4729c.cohuck@redhat.com> (raw)
In-Reply-To: <4f9d9ece-a0c9-b8b8-568a-081e54c2e78a@redhat.com>
On Wed, 23 Jan 2019 12:08:37 +0100
David Hildenbrand <david@redhat.com> wrote:
> On 23.01.19 12:03, Cornelia Huck wrote:
> > On Mon, 21 Jan 2019 14:42:48 +0100
> > David Hildenbrand <david@redhat.com> wrote:
> >
> >> PCI on s390x is really weird and how it was modeled in QEMU might not have
> >> been the right choice. Anyhow, right now it is the case that:
> >> - Hotplugging a PCI device will silently create a zPCI device
> >> (if none is provided)
> >> - Hotunplugging a zPCI device will unplug the PCI device (if any)
> >> - Hotunplugging a PCI device will unplug also the zPCI device
> >> As far as I can see, we can no longer change this behavior. But we
> >> should fix it.
> >>
> >> Both device types are handled via a single hotplug handler call. This
> >> is problematic for various reasons:
> >> 1. Unplugging via the zPCI device allows to unplug PCI bridges as
> >> checks are not performed - bad.
> >
> > Maybe I'm confused here, but how can a zPCI device couple with a bridge?
> >
>
> I was confused, bridges don't attach to a zPCI device. So this remark is
> invalid. Thanks!
>
Ok, I can remove point 1 when applying.
next prev parent reply other threads:[~2019-01-28 11:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 13:42 [Qemu-devel] [PATCH v3 0/2] s390x/pci: hotplug handler fixes and reworks David Hildenbrand
2019-01-21 13:42 ` [Qemu-devel] [PATCH v3 1/2] s390x/pci: Introduce unplug requests and split unplug handler David Hildenbrand
2019-01-23 11:03 ` Cornelia Huck
2019-01-23 11:08 ` David Hildenbrand
2019-01-28 11:27 ` Cornelia Huck [this message]
2019-01-29 13:31 ` Pierre Morel
2019-01-29 15:14 ` David Hildenbrand
2019-01-29 16:54 ` Pierre Morel
2019-01-29 20:27 ` David Hildenbrand
2019-01-30 19:52 ` [Qemu-devel] [qemu-s390x] " Collin Walling
2019-01-31 9:31 ` David Hildenbrand
2019-01-21 13:42 ` [Qemu-devel] [PATCH v3 2/2] s390x/pci: Unplug remaining devices on pcihost reset David Hildenbrand
2019-01-23 11:05 ` Cornelia Huck
2019-01-28 11:28 ` Cornelia Huck
2019-01-29 0:09 ` [Qemu-devel] [qemu-s390x] " Collin Walling
2019-01-29 10:24 ` David Hildenbrand
2019-01-29 13:50 ` Pierre Morel
2019-01-29 15:11 ` David Hildenbrand
2019-01-29 16:50 ` Pierre Morel
2019-01-29 18:20 ` David Hildenbrand
2019-01-29 18:37 ` Cornelia Huck
2019-01-29 18:42 ` Collin Walling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190128122716.35f4729c.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).