From: Kevin Wolf <kwolf@redhat.com>
To: Anton Kuchin <antonkuchin@yandex-team.ru>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
libvir-list@redhat.com, Max Reitz <mreitz@redhat.com>,
Eric Blake <eblake@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Evgeny Yakovlev <wrfsh@yandex-team.ru>,
nsoffer@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qmp: Deprecate query-nodes option of query-blockstats
Date: Mon, 28 Jan 2019 16:37:50 +0100 [thread overview]
Message-ID: <20190128153750.GE5756@localhost.localdomain> (raw)
In-Reply-To: <20190128151521.13875-1-antonkuchin@yandex-team.ru>
Am 28.01.2019 um 16:15 hat Anton Kuchin geschrieben:
> This option is broken since a6baa60807 in v2.9 and returns mostly
> zeroes instead of real stats because actual querring of BlockStats
> that resides in blk is missing.
>
> And it makes no sense because with this option BlockDriverState-s
> are iterated but BlockAcctStats belong to BlockBackend and not BDS
> since 7f0e9da6f13 in v2.5
>
> Signed-off-by: Anton Kuchin <antonkuchin@yandex-team.ru>
Isn't query-nodes the only way to get wr_highest_offset for the protocol
layer? oVirt depends on this, as far as I know.
Kevin
next prev parent reply other threads:[~2019-01-28 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 15:15 [Qemu-devel] [PATCH] qmp: Deprecate query-nodes option of query-blockstats Anton Kuchin
2019-01-28 15:37 ` Kevin Wolf [this message]
2019-01-28 16:12 ` [Qemu-devel] [libvirt] " Daniel P. Berrangé
2019-01-28 16:26 ` Kevin Wolf
2019-01-28 18:02 ` Nir Soffer
2019-01-28 17:33 ` [Qemu-devel] " Anton Kuchin
2019-01-28 16:04 ` Thomas Huth
2019-01-28 16:18 ` [Qemu-devel] [libvirt] " Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190128153750.GE5756@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=antonkuchin@yandex-team.ru \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mreitz@redhat.com \
--cc=nsoffer@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wrfsh@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).