[Qemu-devel] [PATCH] hw/block: clean up stake xen_disk trace entries

[Qemu-devel] [PATCH] hw/block: clean up stake xen_disk trace entries

[Paul Durrant]

This should have been removed then xen_disk.c was removed but I missed them.

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
---
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Max Reitz <mreitz@redhat.com>
---
 hw/block/trace-events | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/hw/block/trace-events b/hw/block/trace-events
index 55e5a5500c..d0851953c5 100644
--- a/hw/block/trace-events
+++ b/hw/block/trace-events
@@ -121,13 +121,6 @@ nvme_ub_db_wr_invalid_cqhead(uint32_t qid, uint16_t new_head) "completion queue
 nvme_ub_db_wr_invalid_sq(uint32_t qid) "submission queue doorbell write for nonexistent queue, sqid=%"PRIu32", ignoring"
 nvme_ub_db_wr_invalid_sqtail(uint32_t qid, uint16_t new_tail) "submission queue doorbell write value beyond queue size, sqid=%"PRIu32", new_head=%"PRIu16", ignoring"
 
-# hw/block/xen_disk.c
-xen_disk_alloc(char *name) "%s"
-xen_disk_init(char *name) "%s"
-xen_disk_connect(char *name) "%s"
-xen_disk_disconnect(char *name) "%s"
-xen_disk_free(char *name) "%s"
-
 # hw/block/xen-block.c
 xen_block_realize(const char *type, uint32_t disk, uint32_t partition) "%s d%up%u"
 xen_block_connect(const char *type, uint32_t disk, uint32_t partition) "%s d%up%u"
-- 
2.20.1.2.gb21ebb6

Re: [Qemu-devel] [PATCH] hw/block: clean up stake xen_disk trace entries

[Paul Durrant]

Ping?

I realize that I typo-ed the commit comment but, assuming that can be fixed, can I get an ack or otherwise on this?

Thanks,

  Paul

> -----Original Message-----
> From: Paul Durrant [mailto:paul.durrant@citrix.com]
> Sent: 22 January 2019 14:52
> To: qemu-devel@nongnu.org; qemu-block@nongnu.org
> Cc: Paul Durrant <Paul.Durrant@citrix.com>; Kevin Wolf <kwolf@redhat.com>;
> Max Reitz <mreitz@redhat.com>
> Subject: [PATCH] hw/block: clean up stake xen_disk trace entries
> 
> This should have been removed then xen_disk.c was removed but I missed
> them.
> 
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> ---
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Max Reitz <mreitz@redhat.com>
> ---
>  hw/block/trace-events | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/hw/block/trace-events b/hw/block/trace-events
> index 55e5a5500c..d0851953c5 100644
> --- a/hw/block/trace-events
> +++ b/hw/block/trace-events
> @@ -121,13 +121,6 @@ nvme_ub_db_wr_invalid_cqhead(uint32_t qid, uint16_t
> new_head) "completion queue
>  nvme_ub_db_wr_invalid_sq(uint32_t qid) "submission queue doorbell write
> for nonexistent queue, sqid=%"PRIu32", ignoring"
>  nvme_ub_db_wr_invalid_sqtail(uint32_t qid, uint16_t new_tail) "submission
> queue doorbell write value beyond queue size, sqid=%"PRIu32",
> new_head=%"PRIu16", ignoring"
> 
> -# hw/block/xen_disk.c
> -xen_disk_alloc(char *name) "%s"
> -xen_disk_init(char *name) "%s"
> -xen_disk_connect(char *name) "%s"
> -xen_disk_disconnect(char *name) "%s"
> -xen_disk_free(char *name) "%s"
> -
>  # hw/block/xen-block.c
>  xen_block_realize(const char *type, uint32_t disk, uint32_t partition)
> "%s d%up%u"
>  xen_block_connect(const char *type, uint32_t disk, uint32_t partition)
> "%s d%up%u"
> --
> 2.20.1.2.gb21ebb6

Re: [Qemu-devel] [PATCH] hw/block: clean up stake xen_disk trace entries

[Philippe Mathieu-Daudé]

Cc'ing QEMU Trivial.

On 1/22/19 3:51 PM, Paul Durrant wrote:
> This should have been removed then xen_disk.c was removed but I missed them.

... when xen_disk.c was removed (19f87870baa) ...

> 
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Max Reitz <mreitz@redhat.com>
> ---
>  hw/block/trace-events | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/hw/block/trace-events b/hw/block/trace-events
> index 55e5a5500c..d0851953c5 100644
> --- a/hw/block/trace-events
> +++ b/hw/block/trace-events
> @@ -121,13 +121,6 @@ nvme_ub_db_wr_invalid_cqhead(uint32_t qid, uint16_t new_head) "completion queue
>  nvme_ub_db_wr_invalid_sq(uint32_t qid) "submission queue doorbell write for nonexistent queue, sqid=%"PRIu32", ignoring"
>  nvme_ub_db_wr_invalid_sqtail(uint32_t qid, uint16_t new_tail) "submission queue doorbell write value beyond queue size, sqid=%"PRIu32", new_head=%"PRIu16", ignoring"
>  
> -# hw/block/xen_disk.c
> -xen_disk_alloc(char *name) "%s"
> -xen_disk_init(char *name) "%s"
> -xen_disk_connect(char *name) "%s"
> -xen_disk_disconnect(char *name) "%s"
> -xen_disk_free(char *name) "%s"
> -
>  # hw/block/xen-block.c
>  xen_block_realize(const char *type, uint32_t disk, uint32_t partition) "%s d%up%u"
>  xen_block_connect(const char *type, uint32_t disk, uint32_t partition) "%s d%up%u"
> 

Re: [Qemu-devel] [PATCH] hw/block: clean up stake xen_disk trace entries

[Peter Maydell]

On Mon, 28 Jan 2019 at 13:41, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> Cc'ing QEMU Trivial.
>
> On 1/22/19 3:51 PM, Paul Durrant wrote:
> > This should have been removed then xen_disk.c was removed but I missed them.
>
> ... when xen_disk.c was removed (19f87870baa) ...

also s/stake/stale/ in the subject line I guess ?

thanks
-- PMM

Re: [Qemu-devel] [PATCH] hw/block: clean up stake xen_disk trace entries

[Kevin Wolf]

Am 22.01.2019 um 15:51 hat Paul Durrant geschrieben:
> This should have been removed then xen_disk.c was removed but I missed them.
> 
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>

Thanks, fixed up the commit message and applied to the block branch.

Kevin