Re: [Qemu-devel] [RFC PATCH] ahci-test: Add dependency to qemu-img tool

[Kevin Wolf <kwolf@redhat.com>]

Am 25.01.2019 um 22:57 hat John Snow geschrieben:
> On 1/25/19 3:34 PM, Philippe Mathieu-Daudé wrote:
> > Since the ahci-test uses qemu-img, add a dependency to build it
> > before using it.
> > This fixes:
> > 
> >   $ gmake check-qtest V=1
> >   QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 QTEST_QEMU_IMG=qemu-img tests/ahci-test
> >   Failed to execute child process "/tmp/qemu-test.19tMRF/qemu-img" (No such file or directory)
> >   ERROR:tests/libqos/libqos.c:192:mkimg: assertion failed: (ret && !err)
> > 
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > ---
> > RFC because while this dependency is valid, I don't think this is the
> > clever way to solve this problem (which is, assuming the host
> > distribution has the qemu-tools installed).
> > I guess remember a thread about it (Eric, John?) where it was asked
> > "What do we want to test, qemu-img or AHCI? Can we trust an unstable
> > version of a tool to verify a device?"
> > 
> [...]
> 
> Reviewed-by: John Snow <jsnow@redhat.com>

Are you taking this through your tree, or through which tree should it
be merged?

Kevin